Add integration test for ListIdentity #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it hits the NIC and not the PLC itself you don't get the same response as reading the equivalent attributes. This also works on non-PLC devices so those can be added here also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new test for listing device identities and modifies an existing test to correct an expected string. The most important changes include the addition of a new test function and updates to the test configuration.
New test for listing device identities:
tests/list_identity_test.go: Added a new test functionTestListIdentityto verify the identity of devices on the network. This includes connecting to the device, retrieving its identity, and validating various identity attributes.tests/test_setup.go: UpdatedTestConfigstruct to include aListIdentifyfield, which holds the configuration for the new identity tests.tests/test_config template.json: Added a new sectionListIdentifyto the test configuration template for specifying device identity details.Correction to existing test:
pack_test.go: Modified the expected string in theTestEncodeStringfunction to "STRING,DINT,SINT[82]" to correct the test validation.