Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Full Support for Multiple XCTest/XCUITest Cases configured in xctestrun File #563

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Enable Full Support for Multiple XCTest/XCUITest Cases configured in xctestrun File #563

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d25fb7
Enable support for multiple XCTest/XCUITest cases configured in xctes…
bahrimootaz Feb 11, 2025
6cc0bc7
resolve threads
bahrimootaz Feb 11, 2025
9017a0e
resolve threads
bahrimootaz Feb 12, 2025
de71704
resolve threads
bahrimootaz Feb 12, 2025
62fd561
use log with error.
bahrimootaz Feb 12, 2025
a9c0f9f
avoid keeping device conn open if we have an issue browsing the apps
bahrimootaz Feb 12, 2025
017823d
use defer to safely close svc
bahrimootaz Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use defer to safely close svc
  • Loading branch information
@bahrimootaz
bahrimootaz committed Feb 12, 2025
commit 017823db469a58847b801201524395bf615ff918
2 changes: 1 addition & 1 deletion ios/testmanagerd/xcuitestrunner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,8 +626,8 @@ func getUserInstalledApps(err error, device ios.DeviceEntry) []installationproxy
log.WithError(err).Debug("we couldn't create ios device connection")
return nil
}
defer svc.Close()
installedApps, err := svc.BrowseUserApps()
svc.Close()
if err != nil {
log.WithError(err).Debug("we couldn't fetch the installed user apps")
return nil
Expand Down
Loading