Enable Full Support for Multiple XCTest/XCUITest Cases configured in xctestrun File #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trun file (#5) * Enable support for multiple XCTest/XCUITest cases configured in xctestrun file. * move the place of one testing method * Update tests
dmissmann
requested changes
Feb 11, 2025
dmissmann
reviewed
Feb 12, 2025
ios/testmanagerd/xcuitestrunner.go
Outdated
Comment on lines
259
to
260
| svc, _ := installationproxy.New(device) | ||
| installedApps, _ := svc.BrowseUserApps() |
There was a problem hiding this comment.
are the errors ignored intentionally here?
Also, svc needs to be closed after we're done
There was a problem hiding this comment.
We introduced a new method to get the installedApps list. errors should not block running the tests
dmissmann
approved these changes
Feb 12, 2025
dmissmann
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the support for xctestrun files with format version 2, building on the initial implementation merged in #559.
With this update, we enable full support for XCUITests by utilizing the parsed test configurations from an xctestrun file.
Testing :
The following scenarios were tested to validate the changes:
✅ Single XCTest case
✅ Single XCUITest case
✅ Single XCUITest case targeting system app
✅ Multiple XCTest cases targeting the same app
✅ Multiple XCTest cases targeting different apps
✅ Multiple XCUITest cases targeting the expected app
✅ Mixed XCUITest and XCTest cases targeting the expected app
✅ Mixed XCUITest and XCTest cases targeting different apps
These enhancements ensure that
go-ioscan reliably handle diverse test configurations parsed from anxctestrunfile in both format versions.