-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: if err & response are nil, return default status #546
Conversation
WalkthroughThe changes introduce a conditional check in the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 22 22
Lines 3883 3886 +3
=======================================
+ Hits 3602 3605 +3
Misses 236 236
Partials 45 45 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- huma.go (1 hunks)
- huma_test.go (1 hunks)
Additional comments not posted (2)
huma.go (1)
1382-1387
: Handle nil output and error gracefully.The added conditional check ensures that when both the output and error are nil, the function sets the HTTP status to
op.DefaultStatus
and returns early. This prevents potential panics or unintended 500 errors, aligning with the PR objectives to enhance robustness.huma_test.go (1)
1435-1457
: Add test case for nil response and error.The new test case "response-nil" ensures that when both the response and error are nil, the system returns the default status code (200) without panicking. This test effectively validates the changes made in the
Register
function to handle this edge case.
Handle a special case where a handler with a response body returns a
nil
error and response struct. This just returns the operation's default status code. This should not be a common case, but is friendlier behavior than having the code panic.Fixes #544
Summary by CodeRabbit
New Features
Tests