Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning nil as response body causes 500 #484

Closed
outofthisworld opened this issue Jun 18, 2024 · 1 comment
Closed

Returning nil as response body causes 500 #484

outofthisworld opened this issue Jun 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@outofthisworld
Copy link

outofthisworld commented Jun 18, 2024

Some package level serialisation/reflection issue (I believe potentially to do with the SchemaLinkTransformer) is making a return of nil cause a 500 error as a response body.

Personally, I think this should be handled internally by the package to Serialise to null, to avoid redundant and unnecessary checking in every handler.

@danielgtaylor danielgtaylor added the bug Something isn't working label Aug 19, 2024
@danielgtaylor
Copy link
Owner

I believe this is a dupe of #544 and fixed in #546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants