fix ref name contains recursive brackets '[]' #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR danielgtaylor#195 fixed ISSUE danielgtaylor#198. But regex matched a shorter string when a generic parammeter is an slice( that means there's embedded brackets).
qdongxu
changed the title
|
@qdongxu thanks, this is unfortunately more complex than I had originally realized. I like your proposal but disagree that the readability of the naming is trivial because these names get directly used in generated SDKs as class/struct names. If at all possible I really want to keep them nice, so I created #200. Please check that out and see if it covers all your use cases and I'll merge and push a new release ASAP. |
|
@danielgtaylor thanks for you quick fix. The new solution works perfect. And I got a bonus from the v2.2.0 release: array from the query parameter. thanks for such a quick release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #195 fixed ISSUE #189. But regex matched a shorter string when a generic parameter is an slice( that means there's embedded brackets).
And the expression is more complex when the generic parameter is another generic type.
Propose to use a full path name as the name is used as an ID and reference in the yaml. Readability is trivial.