fix: schema naming for generics + package types #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 93.40% 93.41%
=======================================
Files 17 17
Lines 2169 2172 +3
=======================================
+ Hits 2026 2029 +3
Misses 105 105
Partials 38 38 ☔ View full report in Codecov by Sentry. |
qdongxu
added a commit
to qdongxu/huma
that referenced
this pull request
Jan 4, 2024
PR danielgtaylor#195 fixed ISSUE danielgtaylor#198. But regex matched a shorter string when a generic parammeter is an slice( that means there's embedded brackets).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the default schema naming function to support generics using types defined in other packages, such as the included test example using
SchemaGeneric[time.Time]. The JSON names and paths generated in the schema are now valid and documentation renders correctly.Fixes #189