Repository navigation
fix: scope DAG detail remote node for SSE #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b47839e
fix: scope DAG detail SSE remote node
yohamta0 d9905cd
fix: preserve DAG detail remote scope
yohamta0 341bef3
Merge remote-tracking branch 'origin/main' into fix-dag-detail-sse-po…
yohamta0 1862a50
fix: keep DAG views live during SSE reconnects
yohamta0 95efd57
fix: avoid redundant YAML worker reloads
yohamta0 170a0bf
fix: preserve DAG detail remote state
yohamta0 37498d1
fix: handle sub dag run SSE updates
yohamta0 9f79c78
fix: defer SSE fallback polling
yohamta0 119e6b2
test: relax conformance command timeout
yohamta0 ad43443
test: verify sub dag SSE hydration
yohamta0 7651469
merge main into SSE polling branch
yohamta0 6abb9c6
test: account for scoped DAG CRUD URLs
yohamta0 1211771
test: avoid regex in scoped URL assertions
yohamta0 d7681df
ci: run e2e only for ui changes
yohamta0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // Copyright (C) 2026 Yota Hamada | ||
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
|
|
||
| import React, { createContext, useContext } from 'react'; | ||
| import { AppBarContext } from './AppBarContext'; | ||
|
|
||
| const RemoteNodeContext = createContext<string | undefined>(undefined); | ||
|
|
||
| function normalizeRemoteNode(value?: string): string | undefined { | ||
| const normalized = value?.trim(); | ||
| return normalized ? normalized : undefined; | ||
| } | ||
|
|
||
| type RemoteNodeProviderProps = { | ||
| remoteNode?: string; | ||
| children: React.ReactNode; | ||
| }; | ||
|
|
||
| export function RemoteNodeProvider({ | ||
| remoteNode, | ||
| children, | ||
| }: RemoteNodeProviderProps) { | ||
| const value = normalizeRemoteNode(remoteNode); | ||
| return ( | ||
| <RemoteNodeContext.Provider value={value}> | ||
| {children} | ||
| </RemoteNodeContext.Provider> | ||
| ); | ||
| } | ||
|
|
||
| export function useRemoteNode(override?: string): string { | ||
| const scopedRemoteNode = useContext(RemoteNodeContext); | ||
| const appBarContext = useContext(AppBarContext); | ||
| return ( | ||
| normalizeRemoteNode(override) || | ||
| normalizeRemoteNode(scopedRemoteNode) || | ||
| normalizeRemoteNode(appBarContext.selectedRemoteNode) || | ||
| 'local' | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.