Repository navigation
fix: scope DAG detail remote node for SSE - #2291
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughIntroduces ChangesRemote Node Context & SSE Infrastructure
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (13)
ui/src/pages/dag-runs/dag-run/index.tsx (1)
1-5:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPL header to this TSX source file.
Line 1 starts with imports, but this file is missing the repository-required GPL v3 header.
Suggested patch
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + import React, { useCallback, useContext, useEffect } from 'react';As per coding guidelines:
**/*.{go,ts,tsx,js,jsx}: Add GPL v3 license headers to source files (managed viamake addlicense).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/pages/dag-runs/dag-run/index.tsx` around lines 1 - 5, The file is missing the required GPL v3 license header at the beginning. Add the GPL v3 license header to the top of the file before the import statements (before the React import and other imports like useParams, AppBarContext, etc.). You can either manually add the header or use the `make addlicense` command to automatically apply the required license headers to all source files as per the repository's coding guidelines.Source: Coding guidelines
ui/src/features/dags/components/dag-details/DAGHeader.tsx (1)
191-216:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAlign breadcrumb render guards with click-handler prerequisites.
Line 191 and Line 214 can still render
hrefvalues built from missingrootDAGRunId/rootDAGRunName, producing malformed links (e.g., open-in-new-tab via middle click), even though click handlers guard against this path.Suggested patch
- {dagRunToDisplay.rootDAGRunId && + {dagRunToDisplay.rootDAGRunId && + dagRunToDisplay.rootDAGRunName && dagRunToDisplay.rootDAGRunId !== dagRunToDisplay.dagRunId && ( @@ - {dagRunToDisplay.parentDAGRunName && + {dagRunToDisplay.parentDAGRunName && dagRunToDisplay.parentDAGRunId && + dagRunToDisplay.rootDAGRunId && + dagRunToDisplay.rootDAGRunName && dagRunToDisplay.parentDAGRunName !== dagRunToDisplay.rootDAGRunName && dagRunToDisplay.parentDAGRunName !== dagRunToDisplay.name && (🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dags/components/dag-details/DAGHeader.tsx` around lines 191 - 216, The second breadcrumb link (parentDAGRunName anchor tag) uses rootDAGRunId and rootDAGRunName in its href URL, but the render guard condition only checks for parentDAGRunName and parentDAGRunId presence, not the root values. Add dagRunToDisplay.rootDAGRunId and dagRunToDisplay.rootDAGRunName existence checks to the conditional guard that wraps the parent DAG run link to ensure all required properties are present before rendering the href, preventing malformed URLs when middle-clicking to open in a new tab.ui/src/features/dags/components/dag-editor/DAGSpecReadOnly.tsx (2)
1-6:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPLv3 header to this TSX file.
This modified source file is missing the required GPL header at the top.
Proposed fix
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + /** * DAGSpecReadOnly component displays a DAG-run specification snapshot. * Root DAG-run snapshots can be edited locally and retried as a new run.As per coding guidelines,
**/*.{go,ts,tsx,js,jsx}files must include GPL v3 license headers (managed viamake addlicense).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dags/components/dag-editor/DAGSpecReadOnly.tsx` around lines 1 - 6, The DAGSpecReadOnly.tsx file is missing the required GPLv3 license header that must be present at the top of all TypeScript and TSX source files according to the project's coding guidelines. Add the GPL v3 license header to the beginning of the file by running the make addlicense command, which will automatically prepend the correct license header to this file and any other source files missing it.Source: Coding guidelines
344-348:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPreserve
remoteNodewhen navigating to the newly created DAG run.Line 344 currently drops node scope from the URL, which can route to the wrong node when the current scope came from URL override.
Proposed fix
- navigate( - `/dag-runs/${encodeURIComponent(dagName)}/${encodeURIComponent( - retryData.dagRunId - )}` - ); + const nextRunPath = `/dag-runs/${encodeURIComponent(dagName)}/${encodeURIComponent( + retryData.dagRunId + )}`; + const nextRunSearch = new URLSearchParams(); + if (remoteNode !== 'local') { + nextRunSearch.set('remoteNode', remoteNode); + } + const nextRunQuery = nextRunSearch.toString(); + navigate(nextRunQuery ? `${nextRunPath}?${nextRunQuery}` : nextRunPath);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dags/components/dag-editor/DAGSpecReadOnly.tsx` around lines 344 - 348, The navigate function call to the newly created DAG run does not preserve the remoteNode scope from the current URL context. Modify the navigate call to include the remoteNode parameter as a query parameter in the destination URL, ensuring it is properly encoded using encodeURIComponent. This will maintain the correct node scope when routing to the DAG run details page, preventing users from being routed to the wrong node when they had a specific node selected via URL override.ui/src/features/dags/components/dag-editor/DAGEditButtons.tsx (1)
1-5:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPLv3 header to this TSX file.
This modified source file is missing the repository-required GPL header, which creates a licensing compliance gap.
Proposed fix
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + /** * DAGEditButtons component provides buttons for renaming and deleting a DAG. *As per coding guidelines,
**/*.{go,ts,tsx,js,jsx}files must include GPL v3 license headers (managed viamake addlicense).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dags/components/dag-editor/DAGEditButtons.tsx` around lines 1 - 5, The DAGEditButtons.tsx file is missing the required GPLv3 license header that should appear at the beginning of all source files. Add the GPLv3 license header comment block at the very top of the file, before the existing JSDoc comment block that starts with the module documentation. You can use the make addlicense command to automatically add the proper license headers to TSX files according to repository standards.Source: Coding guidelines
ui/src/hooks/useStepLogSSE.ts (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPL v3 header to this TypeScript file.
This file is missing the repository-required GPL header.
Suggested patch
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + import { SSEState, useSSE } from './useSSE';As per coding guidelines,
**/*.{go,ts,tsx,js,jsx}must “Add GPL v3 license headers to source files (managed viamake addlicense)”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/hooks/useStepLogSSE.ts` at line 1, The file useStepLogSSE.ts is missing the required GPL v3 license header that must appear at the beginning of all TypeScript source files according to the repository guidelines. Add the GPL v3 license header comment block before the existing import statement at the top of the file. The repository provides a make command (make addlicense) that can be used to automatically add or manage these license headers across source files, which is the recommended approach for maintaining consistency.Source: Coding guidelines
ui/src/hooks/__tests__/useSSE.test.ts (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPL v3 header to this TypeScript test file.
This file is missing the repository-required GPL header.
Suggested patch
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + import { describe, expect, it } from 'vitest';As per coding guidelines,
**/*.{go,ts,tsx,js,jsx}must “Add GPL v3 license headers to source files (managed viamake addlicense)”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/hooks/__tests__/useSSE.test.ts` at line 1, The file useSSE.test.ts is missing the required GPL v3 license header that must be present at the beginning of all TypeScript files according to repository guidelines. Add the GPL v3 license header as a comment block at the very top of the file, before the import statement for describe, expect, and it from vitest. The header should follow the standard GPL v3 format as defined by the repository's addlicense tool.Source: Coding guidelines
ui/src/hooks/__tests__/SSEManager.test.ts (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPL v3 header to this TypeScript test file.
This file is missing the repository-required GPL header.
Suggested patch
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';As per coding guidelines,
**/*.{go,ts,tsx,js,jsx}must “Add GPL v3 license headers to source files (managed viamake addlicense)”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/hooks/__tests__/SSEManager.test.ts` at line 1, The file SSEManager.test.ts is missing the required GPL v3 license header. Add the GPL v3 license header comment block at the very beginning of the file, before the import statement that starts with "import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'". The header should follow the standard GPL v3 format used by the make addlicense command in the repository to ensure consistency with other TypeScript and JavaScript files.Source: Coding guidelines
ui/src/features/dag-runs/components/common/DAGRunActions.tsx (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd required GPLv3 headers to modified TSX files.
This and several other touched TSX files in this cohort are missing the required GPL header. Please run
make addlicensebefore merge to satisfy repository license-compliance rules.As per coding guidelines "
**/*.{go,ts,tsx,js,jsx}: Add GPL v3 license headers to source files (managed viamake addlicense)."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dag-runs/components/common/DAGRunActions.tsx` at line 1, The file DAGRunActions.tsx is missing the required GPLv3 license header at the top of the file. Run the make addlicense command from the repository root to automatically add the GPL v3 license headers to all modified TSX files including DAGRunActions.tsx as per the repository's license-compliance requirements.Source: Coding guidelines
ui/src/features/dags/components/visualization/TimelineChart.tsx (1)
1-12:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPLv3 file header.
This TSX file is missing the repository’s GPL header.
Suggested fix
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + /** * TimelineChart component visualizes the execution timeline of a DAG run.As per coding guidelines,
**/*.{go,ts,tsx,js,jsx}: Add GPL v3 license headers to source files (managed viamake addlicense).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dags/components/visualization/TimelineChart.tsx` around lines 1 - 12, The TimelineChart.tsx file is missing the required GPLv3 license header at the top of the file. Add the GPL v3 license header comment before the existing JSDoc comment for the TimelineChart component. According to the repository's guidelines, this can be done by running the make addlicense command which will automatically add the proper license headers to all source files matching the pattern **/*.{go,ts,tsx,js,jsx}.Source: Coding guidelines
ui/src/features/dags/components/DAGStatus.tsx (1)
270-327:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPreserve
remoteNodein sub-DAG navigation URLs.
navigateToSubDagRunbuilds URLs withoutremoteNode, so sub-run navigation (especiallywindow.open) can resolve to a different node context and show mismatched run data/logs.💡 Suggested fix
@@ - url = `/dag-runs/${rootDAGName}/${dagRunId}?${searchParams.toString()}`; + if (remoteNode !== 'local') { + searchParams.set('remoteNode', remoteNode); + } + url = `/dag-runs/${rootDAGName}/${dagRunId}?${searchParams.toString()}`; @@ - url = `/dags/${fileName}?subDAGRunId=${subDAGRun.dagRunId}&dagRunId=${dagRunId}&step=${node.step.name}&dagRunName=${encodeURIComponent(displayDAGRun.rootDAGRunName || displayDAGRun.name)}`; + const params = new URLSearchParams({ + subDAGRunId: subDAGRun.dagRunId, + dagRunId, + step: node.step.name, + dagRunName: displayDAGRun.rootDAGRunName || displayDAGRun.name, + }); + if (remoteNode !== 'local') { + params.set('remoteNode', remoteNode); + } + url = `/dags/${fileName}?${params.toString()}`; @@ - [displayDAGRun, navigate, fileName] + [displayDAGRun, navigate, fileName, remoteNode] );🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dags/components/DAGStatus.tsx` around lines 270 - 327, The navigateToSubDagRun function constructs URLs for sub-DAG navigation without including the remoteNode parameter, which causes the destination to potentially resolve to a different node context. Add the remoteNode parameter to both URL construction branches: for the DAG run context, add it to the searchParams URLSearchParams object, and for the DAG context, include it in the query string when constructing the `/dags/` URL. Ensure remoteNode is captured from the appropriate source (such as the current URL or displayDAGRun state) and properly encoded when added to the URLs.ui/src/features/dags/components/dag-details/WebhookTab.tsx (1)
1-7:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPLv3 file header.
This TSX file is missing the standard GPL license header block.
Suggested fix
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + /** * WebhookTab component displays webhook configuration for a DAG.As per coding guidelines,
**/*.{go,ts,tsx,js,jsx}: Add GPL v3 license headers to source files (managed viamake addlicense).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dags/components/dag-details/WebhookTab.tsx` around lines 1 - 7, The WebhookTab.tsx file is missing the required GPLv3 license header block that must appear at the very top of all source files. Add the standard GPL v3 license header comment block at the beginning of the file, before the existing JSDoc module comment. This can be done by running the make addlicense command or by manually inserting the appropriate license header that matches your project's standard GPL v3 license format used in other TypeScript and TSX files.Source: Coding guidelines
ui/src/features/dags/components/dag-details/NodeStatusTableRow.tsx (1)
309-331:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPreserve
remoteNodein sub-DAG navigation URLs.Both sub-DAG navigation branches build new URLs but omit
remoteNode, so navigation can fall back to a different node context and show mismatched DAG/DAG-run data.Suggested fix
if (isDAGRunContext) { // For dagRuns, navigate to /dag-runs/{root-dag-name}/{root-dag-run-id}?subDAGRunId=... const searchParams = new URLSearchParams(); searchParams.set('subDAGRunId', subDAGRunId); + searchParams.set('remoteNode', remoteNode); @@ } else { // For DAGs, use the existing approach with query parameters const searchParams = new URLSearchParams(); searchParams.set('subDAGRunId', subDAGRunId); + searchParams.set('remoteNode', remoteNode);As per coding guidelines, UI requests must remain explicitly scoped by
remoteNodein multi-node deployments; these deep links need to carry that scope forward.Also applies to: 341-360
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dags/components/dag-details/NodeStatusTableRow.tsx` around lines 309 - 331, The URL construction logic for sub-DAG navigation is missing the remoteNode parameter in the searchParams, which causes the navigation to lose multi-node deployment context and potentially display mismatched data. In both the if branch (when dagRun.rootDAGRunId exists) and the else branch (when using current dagRun as root), add a searchParams.set call to preserve the remoteNode value before constructing the final URL using the searchParams.toString() method. Apply this same fix to the other location mentioned in the comment.Source: Coding guidelines
🧹 Nitpick comments (1)
ui/src/hooks/useSSECacheSync.ts (1)
1-1: ⚡ Quick winAdd the required GPL v3 header to this TypeScript file.
Please run
make addlicenseso this touched file includes the standard license header.As per coding guidelines,
**/*.{go,ts,tsx,js,jsx}must include GPL v3 license headers managed viamake addlicense.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/hooks/useSSECacheSync.ts` at line 1, The useSSECacheSync.ts file is missing the required GPL v3 license header that must be present at the top of all TypeScript files according to coding guidelines. Add the standard GPL v3 license header to the beginning of this file by running the `make addlicense` command, which will automatically insert the proper license header and ensure compliance with the project's licensing requirements for all TypeScript files.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/src/contexts/__tests__/RemoteNodeContext.test.tsx`:
- Line 1: The RemoteNodeContext.test.tsx file is missing the required GPL v3
license header at the beginning of the file. Add the GPL v3 license header to
the top of this TSX file by running the make addlicense command which
automatically manages license headers for source files matching the pattern
*.{go,ts,tsx,js,jsx}. This will ensure the file complies with the coding
guidelines for license headers in source files.
In `@ui/src/contexts/RemoteNodeContext.tsx`:
- Around line 18-31: The code is checking for empty whitespace using trim() for
truthiness validation, but is returning untrimmed values which can propagate
spaces that break downstream operations. In the RemoteNodeProvider function,
modify the value assignment to return the trimmed version of remoteNode instead
of the original value. In the useRemoteNode function, ensure that the returned
value from the override parameter, scopedRemoteNode, and
appBarContext.selectedRemoteNode are all trimmed before being returned to remove
any leading or trailing whitespace.
In `@ui/src/features/dag-runs/components/dag-run-details/DAGRunDetailsModal.tsx`:
- Around line 160-167: The code in the DAGRunDetailsModal component currently
skips setting the remoteNode query parameter when its value is 'local', but this
causes the URL to fall back to the AppBar-selected remote node upon navigation,
breaking scope consistency. Modify the logic where searchParams is constructed
to always include the remoteNode parameter in the query string regardless of its
value, including when it is 'local'. Remove the conditional check on line 161
that currently prevents 'local' from being added to searchParams, ensuring the
explicit node scope is always preserved in the fullscreen URL.
In `@ui/src/features/dag-runs/components/dag-run-details/DAGRunDetailsPanel.tsx`:
- Around line 79-86: The condition checking `if (remoteNode !== 'local')` before
setting the remoteNode parameter should be removed to ensure the remoteNode is
always included in the URL regardless of its value. Currently, when remoteNode
is 'local', it gets omitted from the searchParams, which can cause the node to
resolve differently after navigation when the AppBar has a non-local selection.
Simply remove the conditional check and always call
searchParams.set('remoteNode', remoteNode) to maintain consistent scoped-node
behavior across navigations.
In `@ui/src/features/dags/components/approval/ApprovalTab.tsx`:
- Around line 1-3: The ApprovalTab.tsx file is missing the required GPL v3
license header that should appear at the top of all source files in the
repository. Add the standard GPL v3 license header block at the very beginning
of the file, before the import statements. You can use the command make
addlicense to automatically apply the correct license headers to source files,
or manually add the GPL v3 header comment block that matches the format used in
other TypeScript and TSX files in the repository.
In `@ui/src/features/dags/components/chat-history/StepMessagesTable.tsx`:
- Around line 1-3: The StepMessagesTable.tsx file is missing the required GPL v3
license header that should appear at the very beginning of the file before any
imports. Add the standard GPL v3 license header comment block at the top of the
file before the import statements for ChatMessageRole, Markdown, and
useRemoteNode. You can use the make addlicense command as mentioned in the
coding guidelines to automatically add the license headers to all source files
in the project.
In `@ui/src/features/dags/components/common/InlineLogViewer.tsx`:
- Line 1: The file InlineLogViewer.tsx is missing the required GPL v3 license
header at the top of the file. Run the make addlicense command to automatically
add the GPL v3 license header to this file and any other modified TSX/TS files
in the cohort that are missing it (LiveSwitch.tsx, NodeStatusTableRow.tsx,
SubDAGRunsList.tsx). This will ensure all modified source files comply with the
coding guidelines that require GPL v3 headers for all *.{go,ts,tsx,js,jsx}
files.
In `@ui/src/features/dags/components/dag-details/WebhookTab.tsx`:
- Around line 153-155: The remoteNode value is being concatenated directly into
fetch URLs in query strings without proper URL encoding, which can cause issues
with reserved characters in node names. Apply URL encoding to remoteNode when
building query strings in all fetch calls throughout this file, including in the
getRemoteNodeParam function and at the other locations mentioned (lines 163-165,
214-216, 243-245, 273-274, 309-310). Use the standard encodeURIComponent
function to safely encode the remoteNode variable before it is inserted into any
URL query parameters to prevent query parsing corruption.
In `@ui/src/features/dags/components/dag-execution/ParallelExecutionModal.tsx`:
- Around line 160-170: The setSelectedIndex callbacks in both the ArrowDown and
ArrowUp keyboard event handlers perform modulo arithmetic using
filteredSubRuns.length, which produces NaN when the filtered list is empty
(length equals 0), leaving selectedIndex in an invalid state. Guard against this
by checking if filteredSubRuns.length is greater than 0 before performing the
modulo arithmetic; if the length is 0, set selectedIndex to null instead of
attempting the calculation.
---
Outside diff comments:
In `@ui/src/features/dag-runs/components/common/DAGRunActions.tsx`:
- Line 1: The file DAGRunActions.tsx is missing the required GPLv3 license
header at the top of the file. Run the make addlicense command from the
repository root to automatically add the GPL v3 license headers to all modified
TSX files including DAGRunActions.tsx as per the repository's license-compliance
requirements.
In `@ui/src/features/dags/components/dag-details/DAGHeader.tsx`:
- Around line 191-216: The second breadcrumb link (parentDAGRunName anchor tag)
uses rootDAGRunId and rootDAGRunName in its href URL, but the render guard
condition only checks for parentDAGRunName and parentDAGRunId presence, not the
root values. Add dagRunToDisplay.rootDAGRunId and dagRunToDisplay.rootDAGRunName
existence checks to the conditional guard that wraps the parent DAG run link to
ensure all required properties are present before rendering the href, preventing
malformed URLs when middle-clicking to open in a new tab.
In `@ui/src/features/dags/components/dag-details/NodeStatusTableRow.tsx`:
- Around line 309-331: The URL construction logic for sub-DAG navigation is
missing the remoteNode parameter in the searchParams, which causes the
navigation to lose multi-node deployment context and potentially display
mismatched data. In both the if branch (when dagRun.rootDAGRunId exists) and the
else branch (when using current dagRun as root), add a searchParams.set call to
preserve the remoteNode value before constructing the final URL using the
searchParams.toString() method. Apply this same fix to the other location
mentioned in the comment.
In `@ui/src/features/dags/components/dag-details/WebhookTab.tsx`:
- Around line 1-7: The WebhookTab.tsx file is missing the required GPLv3 license
header block that must appear at the very top of all source files. Add the
standard GPL v3 license header comment block at the beginning of the file,
before the existing JSDoc module comment. This can be done by running the make
addlicense command or by manually inserting the appropriate license header that
matches your project's standard GPL v3 license format used in other TypeScript
and TSX files.
In `@ui/src/features/dags/components/dag-editor/DAGEditButtons.tsx`:
- Around line 1-5: The DAGEditButtons.tsx file is missing the required GPLv3
license header that should appear at the beginning of all source files. Add the
GPLv3 license header comment block at the very top of the file, before the
existing JSDoc comment block that starts with the module documentation. You can
use the make addlicense command to automatically add the proper license headers
to TSX files according to repository standards.
In `@ui/src/features/dags/components/dag-editor/DAGSpecReadOnly.tsx`:
- Around line 1-6: The DAGSpecReadOnly.tsx file is missing the required GPLv3
license header that must be present at the top of all TypeScript and TSX source
files according to the project's coding guidelines. Add the GPL v3 license
header to the beginning of the file by running the make addlicense command,
which will automatically prepend the correct license header to this file and any
other source files missing it.
- Around line 344-348: The navigate function call to the newly created DAG run
does not preserve the remoteNode scope from the current URL context. Modify the
navigate call to include the remoteNode parameter as a query parameter in the
destination URL, ensuring it is properly encoded using encodeURIComponent. This
will maintain the correct node scope when routing to the DAG run details page,
preventing users from being routed to the wrong node when they had a specific
node selected via URL override.
In `@ui/src/features/dags/components/DAGStatus.tsx`:
- Around line 270-327: The navigateToSubDagRun function constructs URLs for
sub-DAG navigation without including the remoteNode parameter, which causes the
destination to potentially resolve to a different node context. Add the
remoteNode parameter to both URL construction branches: for the DAG run context,
add it to the searchParams URLSearchParams object, and for the DAG context,
include it in the query string when constructing the `/dags/` URL. Ensure
remoteNode is captured from the appropriate source (such as the current URL or
displayDAGRun state) and properly encoded when added to the URLs.
In `@ui/src/features/dags/components/visualization/TimelineChart.tsx`:
- Around line 1-12: The TimelineChart.tsx file is missing the required GPLv3
license header at the top of the file. Add the GPL v3 license header comment
before the existing JSDoc comment for the TimelineChart component. According to
the repository's guidelines, this can be done by running the make addlicense
command which will automatically add the proper license headers to all source
files matching the pattern **/*.{go,ts,tsx,js,jsx}.
In `@ui/src/hooks/__tests__/SSEManager.test.ts`:
- Line 1: The file SSEManager.test.ts is missing the required GPL v3 license
header. Add the GPL v3 license header comment block at the very beginning of the
file, before the import statement that starts with "import { afterEach,
beforeEach, describe, expect, it, vi } from 'vitest'". The header should follow
the standard GPL v3 format used by the make addlicense command in the repository
to ensure consistency with other TypeScript and JavaScript files.
In `@ui/src/hooks/__tests__/useSSE.test.ts`:
- Line 1: The file useSSE.test.ts is missing the required GPL v3 license header
that must be present at the beginning of all TypeScript files according to
repository guidelines. Add the GPL v3 license header as a comment block at the
very top of the file, before the import statement for describe, expect, and it
from vitest. The header should follow the standard GPL v3 format as defined by
the repository's addlicense tool.
In `@ui/src/hooks/useStepLogSSE.ts`:
- Line 1: The file useStepLogSSE.ts is missing the required GPL v3 license
header that must appear at the beginning of all TypeScript source files
according to the repository guidelines. Add the GPL v3 license header comment
block before the existing import statement at the top of the file. The
repository provides a make command (make addlicense) that can be used to
automatically add or manage these license headers across source files, which is
the recommended approach for maintaining consistency.
In `@ui/src/pages/dag-runs/dag-run/index.tsx`:
- Around line 1-5: The file is missing the required GPL v3 license header at the
beginning. Add the GPL v3 license header to the top of the file before the
import statements (before the React import and other imports like useParams,
AppBarContext, etc.). You can either manually add the header or use the `make
addlicense` command to automatically apply the required license headers to all
source files as per the repository's coding guidelines.
---
Nitpick comments:
In `@ui/src/hooks/useSSECacheSync.ts`:
- Line 1: The useSSECacheSync.ts file is missing the required GPL v3 license
header that must be present at the top of all TypeScript files according to
coding guidelines. Add the standard GPL v3 license header to the beginning of
this file by running the `make addlicense` command, which will automatically
insert the proper license header and ensure compliance with the project's
licensing requirements for all TypeScript files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 87ede7a9-1be4-4d66-9a88-37bd0bcc703a
📒 Files selected for processing (44)
ui/src/contexts/RemoteNodeContext.tsxui/src/contexts/__tests__/RemoteNodeContext.test.tsxui/src/features/dag-runs/components/common/DAGRunActions.tsxui/src/features/dag-runs/components/dag-run-details/DAGRunDetailsModal.tsxui/src/features/dag-runs/components/dag-run-details/DAGRunDetailsPanel.tsxui/src/features/dag-runs/components/dag-run-details/DAGRunOutputs.tsxui/src/features/dags/components/DAGStatus.tsxui/src/features/dags/components/approval/ApprovalTab.tsxui/src/features/dags/components/artifacts/ArtifactsTab.tsxui/src/features/dags/components/chat-history/StepMessagesTable.tsxui/src/features/dags/components/common/DAGActions.tsxui/src/features/dags/components/common/InlineLogViewer.tsxui/src/features/dags/components/common/LiveSwitch.tsxui/src/features/dags/components/dag-details/DAGDetailsContent.tsxui/src/features/dags/components/dag-details/DAGDetailsPanel.tsxui/src/features/dags/components/dag-details/DAGDetailsSidePanel.tsxui/src/features/dags/components/dag-details/DAGHeader.tsxui/src/features/dags/components/dag-details/DAGSettingsTab.tsxui/src/features/dags/components/dag-details/IncidentsTab.tsxui/src/features/dags/components/dag-details/NodeStatusTableRow.tsxui/src/features/dags/components/dag-details/NotificationsTab.tsxui/src/features/dags/components/dag-details/SubDAGRunsList.tsxui/src/features/dags/components/dag-details/WebhookTab.tsxui/src/features/dags/components/dag-details/__tests__/DAGDetailsPanel.test.tsxui/src/features/dags/components/dag-editor/DAGEditButtons.tsxui/src/features/dags/components/dag-editor/DAGSpec.tsxui/src/features/dags/components/dag-editor/DAGSpecReadOnly.tsxui/src/features/dags/components/dag-execution/DAGExecutionHistory.tsxui/src/features/dags/components/dag-execution/ExecutionLog.tsxui/src/features/dags/components/dag-execution/ParallelExecutionModal.tsxui/src/features/dags/components/dag-execution/StepLog.tsxui/src/features/dags/components/visualization/TimelineChart.tsxui/src/hooks/SSEManager.tsui/src/hooks/__tests__/SSEManager.test.tsui/src/hooks/__tests__/useSSE.test.tsui/src/hooks/useDAGHistorySSE.tsui/src/hooks/useDAGRunLogsSSE.tsui/src/hooks/useDAGSSE.tsui/src/hooks/useSSE.tsui/src/hooks/useSSECacheSync.tsui/src/hooks/useStepLogSSE.tsui/src/pages/dag-runs/dag-run/index.tsxui/src/pages/dags/dag/index.tsxui/src/pages/design/index.tsx
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
ui/webpack.common.js (1)
1-2:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required GPL v3 header to this modified JS source file.
This file is changed in this PR but is missing the mandated license header.
As per coding guidelines:
**/*.{go,ts,tsx,js,jsx}: “Add GPL v3 license headers to source files (managed via make addlicense)”.Suggested patch
+// Copyright (C) 2026 Yota Hamada +// SPDX-License-Identifier: GPL-3.0-or-later + const MonacoWebpackPlugin = require('monaco-editor-webpack-plugin'); const path = require('path');🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/webpack.common.js` around lines 1 - 2, Add the GPL v3 license header to the beginning of the file before the existing require statements for MonacoWebpackPlugin and path. The license header should be a comment block containing the standard GPL v3 text that is mandated for all JavaScript source files in this project according to the coding guidelines. This can be added manually or by running the make addlicense command mentioned in the guidelines to automatically apply the header to modified files.Source: Coding guidelines
ui/src/hooks/useSSECacheSync.ts (1)
12-18:⚠️ Potential issue | 🟠 Major | ⚡ Quick winFallback polling is enabled too early during SSE reconnect backoff.
shouldPoll = !sseUsableturns polling on for all disconnected states, includingisConnecting=truebefore fallback threshold. That causes redundant polling during retry backoff and increases request pressure.Suggested fix
export function sseFallbackOptions( sseResult: SSEState<unknown>, fallbackInterval: number = 2000 ) { - const sseUsable = sseResult.isConnected && !sseResult.shouldUseFallback; - const shouldPoll = !sseUsable; + const shouldPoll = + sseResult.shouldUseFallback || + (!sseResult.isConnected && !sseResult.isConnecting); return { revalidateOnMount: true, revalidateIfStale: shouldPoll, revalidateOnFocus: shouldPoll, refreshInterval: shouldPoll ? fallbackInterval : 0, }; }Downstream impact: update the connecting-state expectation added in
ui/src/hooks/__tests__/useSSE.test.tsaccordingly.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/hooks/useSSECacheSync.ts` around lines 12 - 18, The shouldPoll calculation in useSSECacheSync is too aggressive because using !sseUsable enables polling during the isConnecting state before the shouldUseFallback threshold is reached. Instead of shouldPoll = !sseUsable, change it to check shouldPoll = sseResult.shouldUseFallback so that polling only activates when the SSE fallback is actually needed, allowing reconnection attempts to complete without redundant polling. Additionally, update the connecting-state expectations in the useSSE.test.ts file to reflect that polling should not be enabled while the system is in a connecting state waiting for the fallback threshold.
🧹 Nitpick comments (1)
ui/src/features/dag-runs/hooks/__tests__/useBoundedDAGRunDetails.test.tsx (1)
141-168: ⚡ Quick winAdd a sub-DAG name-mismatch regression test for SSE acceptance.
Current additions validate connecting polling, but not the sub-DAG path where name filtering should be bypassed. A focused case here would prevent regressions in
matchesRequestedDAGRunDetailswiring.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/src/features/dag-runs/hooks/__tests__/useBoundedDAGRunDetails.test.tsx` around lines 141 - 168, Add a new test case to validate the sub-DAG name-mismatch regression scenario for the useBoundedDAGRunDetails hook. The test should verify that when handling sub-DAGs, the matchesRequestedDAGRunDetails function bypasses name filtering logic as expected. Create this test alongside the existing "keeps polling while the DAG-run SSE topic is still connecting" test to ensure this filtering bypass behavior does not regress in future changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/src/features/dag-runs/hooks/useBoundedDAGRunDetails.ts`:
- Around line 239-243: The matchesRequestedDAGRunDetails call unconditionally
filters SSE payloads by target name, which causes valid updates to be rejected
in sub-DAG mode where name context differs. Modify the call to conditionally
pass the target?.name parameter only when not operating in sub-DAG mode. Check
the context to determine if the target is a sub-DAG, and if so, pass undefined
or null for the name parameter to matchesRequestedDAGRunDetails instead of
target?.name, allowing SSE updates to be properly processed without stale
details suppression.
In `@ui/src/features/dags/components/DAGStatus.tsx`:
- Line 336: The `onSelectStepOnGraph` callback can retain stale closures with
outdated remoteNode context when a remote-node switch occurs. Locate the
definition of `onSelectStepOnGraph` (likely a useCallback hook) and add
`remoteNode` to its dependency array to ensure the callback is properly
recreated whenever the remoteNode changes, preventing it from using outdated
node context in navigation operations.
---
Outside diff comments:
In `@ui/src/hooks/useSSECacheSync.ts`:
- Around line 12-18: The shouldPoll calculation in useSSECacheSync is too
aggressive because using !sseUsable enables polling during the isConnecting
state before the shouldUseFallback threshold is reached. Instead of shouldPoll =
!sseUsable, change it to check shouldPoll = sseResult.shouldUseFallback so that
polling only activates when the SSE fallback is actually needed, allowing
reconnection attempts to complete without redundant polling. Additionally,
update the connecting-state expectations in the useSSE.test.ts file to reflect
that polling should not be enabled while the system is in a connecting state
waiting for the fallback threshold.
In `@ui/webpack.common.js`:
- Around line 1-2: Add the GPL v3 license header to the beginning of the file
before the existing require statements for MonacoWebpackPlugin and path. The
license header should be a comment block containing the standard GPL v3 text
that is mandated for all JavaScript source files in this project according to
the coding guidelines. This can be added manually or by running the make
addlicense command mentioned in the guidelines to automatically apply the header
to modified files.
---
Nitpick comments:
In `@ui/src/features/dag-runs/hooks/__tests__/useBoundedDAGRunDetails.test.tsx`:
- Around line 141-168: Add a new test case to validate the sub-DAG name-mismatch
regression scenario for the useBoundedDAGRunDetails hook. The test should verify
that when handling sub-DAGs, the matchesRequestedDAGRunDetails function bypasses
name filtering logic as expected. Create this test alongside the existing "keeps
polling while the DAG-run SSE topic is still connecting" test to ensure this
filtering bypass behavior does not regress in future changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 15261e25-ca97-45a4-939b-5dddfcbc93d6
📒 Files selected for processing (56)
internal/service/frontend/server.gointernal/service/frontend/server_test.gospecs/003-value-resolution.mdui/src/__tests__/webpack.prod.test.tsui/src/contexts/RemoteNodeContext.tsxui/src/contexts/__tests__/RemoteNodeContext.test.tsxui/src/features/dag-runs/components/common/DAGRunActions.tsxui/src/features/dag-runs/components/dag-run-details/DAGRunDetailsModal.tsxui/src/features/dag-runs/components/dag-run-details/DAGRunDetailsPanel.tsxui/src/features/dag-runs/components/dag-run-details/DAGRunHeader.tsxui/src/features/dag-runs/components/dag-run-details/DAGRunOutputs.tsxui/src/features/dag-runs/components/dag-run-details/__tests__/DAGRunDetailsPanel.test.tsxui/src/features/dag-runs/hooks/__tests__/dagRunDetailsRequest.test.tsui/src/features/dag-runs/hooks/__tests__/useBoundedDAGRunDetails.test.tsxui/src/features/dag-runs/hooks/__tests__/useExactDAGRuns.test.tsxui/src/features/dag-runs/hooks/dagRunDetailsRequest.tsui/src/features/dag-runs/hooks/dagRunPagination.tsui/src/features/dag-runs/hooks/useBoundedDAGRunDetails.tsui/src/features/dag-runs/lib/__tests__/dagRunUrls.test.tsui/src/features/dag-runs/lib/dagRunUrls.tsui/src/features/dags/components/DAGStatus.tsxui/src/features/dags/components/approval/ApprovalTab.tsxui/src/features/dags/components/chat-history/StepMessagesTable.tsxui/src/features/dags/components/common/InlineLogViewer.tsxui/src/features/dags/components/common/LiveSwitch.tsxui/src/features/dags/components/dag-details/DAGDetailsPanel.tsxui/src/features/dags/components/dag-details/DAGDetailsSidePanel.tsxui/src/features/dags/components/dag-details/DAGHeader.tsxui/src/features/dags/components/dag-details/NodeStatusTableRow.tsxui/src/features/dags/components/dag-details/SubDAGRunsList.tsxui/src/features/dags/components/dag-details/WebhookTab.tsxui/src/features/dags/components/dag-editor/DAGEditButtons.tsxui/src/features/dags/components/dag-editor/DAGEditor.tsxui/src/features/dags/components/dag-editor/DAGSpec.tsxui/src/features/dags/components/dag-editor/DAGSpecReadOnly.tsxui/src/features/dags/components/dag-editor/__tests__/DAGSpecReadOnly.test.tsxui/src/features/dags/components/dag-editor/__tests__/schemaRegistration.test.tsui/src/features/dags/components/dag-editor/schemaRegistration.tsui/src/features/dags/components/dag-execution/DAGExecutionHistory.tsxui/src/features/dags/components/dag-execution/ExecutionLog.tsxui/src/features/dags/components/dag-execution/ParallelExecutionModal.tsxui/src/features/dags/components/dag-execution/StepLog.tsxui/src/features/dags/components/visualization/TimelineChart.tsxui/src/hooks/SSEManager.tsui/src/hooks/__tests__/SSEManager.test.tsui/src/hooks/__tests__/useSSE.test.tsui/src/hooks/useDAGHistorySSE.tsui/src/hooks/useDAGRunLogsSSE.tsui/src/hooks/useDAGSSE.tsui/src/hooks/useSSE.tsui/src/hooks/useSSECacheSync.tsui/src/hooks/useStepLogSSE.tsui/src/pages/dag-runs/dag-run/index.tsxui/src/pages/dags/dag/index.tsxui/src/pages/design/index.tsxui/webpack.common.js
✅ Files skipped from review due to trivial changes (1)
- specs/003-value-resolution.md
🚧 Files skipped from review as they are similar to previous changes (19)
- ui/src/hooks/useStepLogSSE.ts
- ui/src/hooks/useDAGRunLogsSSE.ts
- ui/src/contexts/RemoteNodeContext.tsx
- ui/src/hooks/useDAGHistorySSE.ts
- ui/src/hooks/useDAGSSE.ts
- ui/src/contexts/tests/RemoteNodeContext.test.tsx
- ui/src/features/dags/components/dag-details/DAGDetailsPanel.tsx
- ui/src/features/dags/components/chat-history/StepMessagesTable.tsx
- ui/src/features/dags/components/dag-details/SubDAGRunsList.tsx
- ui/src/features/dags/components/dag-execution/ExecutionLog.tsx
- ui/src/features/dags/components/visualization/TimelineChart.tsx
- ui/src/features/dags/components/common/InlineLogViewer.tsx
- ui/src/features/dags/components/dag-details/DAGHeader.tsx
- ui/src/features/dag-runs/components/dag-run-details/DAGRunOutputs.tsx
- ui/src/features/dags/components/approval/ApprovalTab.tsx
- ui/src/features/dags/components/dag-execution/DAGExecutionHistory.tsx
- ui/src/features/dag-runs/components/common/DAGRunActions.tsx
- ui/src/features/dags/components/dag-details/DAGDetailsSidePanel.tsx
- ui/src/features/dags/components/dag-editor/DAGSpecReadOnly.tsx
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/src/features/dag-runs/hooks/__tests__/useBoundedDAGRunDetails.test.tsx`:
- Around line 286-323: The test assertion passes regardless of whether SSE
hydration is actually being used because both the fetchDAGRunDetailsMock and
subDAGRunSSEState.current are returning identical payloads. To make the SSE
hydration path verifiable independently, modify the fetchDAGRunDetailsMock to
return different data (such as a different dagRunId or name value) while keeping
subDAGRunSSEState.current with the expected values that should be returned by
the useBoundedDAGRunDetails hook. This way, the expect statement will only pass
if the hook is truly using the SSE hydration data and not just the fetch result.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e8829835-ca8c-459d-9d06-623d47d5eec5
📒 Files selected for processing (6)
ui/src/features/dag-runs/hooks/__tests__/useBoundedDAGRunDetails.test.tsxui/src/features/dag-runs/hooks/useBoundedDAGRunDetails.tsui/src/features/dags/components/DAGStatus.tsxui/src/hooks/__tests__/useSSE.test.tsui/src/hooks/useSSECacheSync.tsui/webpack.common.js
🚧 Files skipped from review as they are similar to previous changes (3)
- ui/webpack.common.js
- ui/src/hooks/useSSECacheSync.ts
- ui/src/features/dags/components/DAGStatus.tsx
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/e2e/dag-crud.spec.ts`:
- Around line 79-81: The `newName` variable is being directly interpolated into
the RegExp constructor on line 80 without escaping special regex characters. If
the DAG name contains regex metacharacters like `.`, `+`, `*`, or `?`, the
assertion will fail or match unintended URLs. Escape the `newName` string using
a regex escape function (or by replacing special regex characters with their
escaped versions) before constructing the RegExp pattern in the toHaveURL
assertion, so that literal characters in the DAG name are treated as literals
rather than regex syntax.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cb42cde0-4aae-4f8c-813b-8cb82223f9c8
📒 Files selected for processing (1)
ui/e2e/dag-crud.spec.ts
Member
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by cubic
Scopes the remote node across DAG and DAG‑run detail views and all SSE topics, preserving that scope in navigation and deep links. Tightens sub‑DAG SSE correctness, defers polling until SSE is unhealthy, and ships immutable, content‑hashed Monaco YAML workers.
Bug Fixes
remoteNodevia?remoteNodeand scoped links across REST, SSE, logs, artifacts, outputs, approvals, incidents, timeline, chat, editor/design, sub‑runs, and DAG CRUD.useExactDAGRuns,useBoundedDAGRunDetails, pagination, andsseFallbackOptions.latest; hydrate sub‑DAG details; reset details on target change..worker.js; server serves workers withimmutablecache headers.Refactors
RemoteNodeContext/useRemoteNode; wrapped DAG/DAG‑run surfaces; pages resolve scope from URL or app bar.useSSEand all DAG/DAG‑run SSE hooks to accept a remote node; addeddagRunUrlshelpers to keep remote and sub‑DAG context in deep links.schemaRegistrationutilities to dedupe YAML schema registrations and reducemonaco-editorworker/model churn.ui/**changes.Written for commit d7681df. Summary will update on new commits.
Summary by CodeRabbit