Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#830] executor/docker: support network configuration #835

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Feb 13, 2025

Resolves #830

@yohamta yohamta changed the title [#830] executor/docker: Allow network configuration [#830] executor/docker: support network configuration Feb 13, 2025
@yohamta yohamta merged commit 2810502 into main Feb 13, 2025
4 checks passed
@yohamta yohamta deleted the 830-docker-network branch February 13, 2025 11:55
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 55.82%. Comparing base (bbff142) to head (ecdb99e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/digraph/executor/docker.go 0.00% 50 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   55.94%   55.82%   -0.12%     
==========================================
  Files          75       75              
  Lines        8096     8118      +22     
==========================================
+ Hits         4529     4532       +3     
- Misses       3172     3192      +20     
+ Partials      395      394       -1     
Files with missing lines Coverage Δ
internal/digraph/executor/docker.go 0.71% <0.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbff142...ecdb99e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add networking configuration for docker executor
1 participant