fix(ci): docker image push fixes

[d33bs]

Description

This PR fixes a Docker image push trigger which didn't occur after merging in #377 . I believe this GH Actions run should have seen a push to Docker hub, but the if-conditions failed to trigger.

It also fixes incorrect Dockerfile path and tag naming witnessed after a scheduled job failure.

Thanks for any feedback you may have!

References #214

What is the nature of your change?

• Bug fix (fixes an issue).
• Enhancement (adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).
• This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

• I have read the CONTRIBUTING.md guidelines.
• My code follows the style guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• New and existing unit tests pass locally with my changes.
• I have added tests that prove my fix is effective or that my feature works.
• I have deleted all non-relevant text in this pull request template.

[kenibrewer]

Sorry for jinxing this. 😅

[d33bs]

Absolutely no worries @kenibrewer ! Thanks for the earlier review. After seeing the scheduled job failure I decided to apply further fixes for the image tags, Dockerfile location, and removing tests from the build source (I believe the earlier copy for testing would persist into the production builds). I've re-requested a review as the changes are more broad than they initially were.

additional changes

[kenibrewer]

Thanks for re-requesting review here. There's one change we should make to the Dockerfile if we want a slimmed down production build.

[kenibrewer]

Here's another possible change at your discretion. This would make it a bit easier with the context management.

1. Move ./build/docker/Dockerfile to ./Dockerfile
2. Add the tests directory as an include for the sdist build artifact but not wheel (instructions)

I think the end result would be that the commands docker build . --target testing would work both in a cloned repo root or in an extracted sdist.

[d33bs]

Thanks @kenibrewer ! I applied the changes you mentioned but held off for now on the Dockerfile / pyproject.toml changes as I wasn't as certain about impacts or implementation here. I'll create a new issue as these feel like great future additions.

[kenibrewer]

Looks good! Thanks for capturing the new issue

[d33bs]

Thanks @kenibrewer ! Merging this in.