-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): add docker hub push capabilities #377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking very clean, but there's a use of download_artifact I think will break and I have an additional suggestion around merging the docker "build-test" action and the "build-push" action into a unified "build-test-push" action.
aa55867
to
9b61af8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 56 56
Lines 3136 3137 +1
=======================================
+ Hits 2978 2979 +1
Misses 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9b61af8
to
f45adca
Compare
Thanks @gwaybio and @kenibrewer for your reviews! I've worked towards addressing these and believe things are now ready for a re-review when there's a moment. |
d072b6b
to
2e875a6
Compare
Co-Authored-By: Ken Brewer <kenibrewer@users.noreply.github.com>
2e875a6
to
7412759
Compare
Hi @bethac07 and @kenibrewer , I've added some changes based on your comments and have re-requested your review. Please don't hesitate to let me know if I should make any further changes to help ready this for pycytominer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions to make certain if checks a bit more restrictive. But otherwise this looks good to me and seems like implement's @bethac07 's tagging suggestions well.
Excited to see this merged so we can hotfix whatever github actions corner case we inevitably missed despite triple checking every line!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Ken, I'm sure some hotfixing will be required just due to the laws of coding/the universe, but awesome job!
Co-authored-by: Ken Brewer <kenibrewer@users.noreply.github.com>
Thank you so much @kenibrewer, @bethac07, and @gwaybio for your reviews and great suggestions throughout! Going to squash and merge this in. |
Description
This PR continues the efforts surrounding #214 to push Docker images to Docker Hub using various triggers from GitHub Actions. I tried to abide the spec mentioned by @bethac07 (thanks Beth!) with slight adjustment to add the dynamic version to each tag along with the commit hash (which includes a commit hash for non-release-based versions). Please don't hesitate to let me know if I should change the tagging or other aspects to meet the goals here.
Open question I had while creating this: when would be best to create a scheduled push for Docker images? I chose Wednesdays as a time where challenges (if there were any) would be quite visible and could be resolved before week-end. I can also see how Mondays, Fridays, or sometime over the weekend would be good too.
Once this is merged, I believe we should see a new push triggered, and will likely be able to reach back out to Docker for more support surrounding their DSOS program.
Thank you in advance for any thoughts and suggestions you may have on this!
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.