Get unique and simpler selectors #15
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functionality - Changed Babel preset from "latest" to "@babel/preset-env" for better compatibility. - Added new utility function `getDataAttributes` to extract data-* attributes from elements. - Enhanced selector logic to prioritize data-* attributes in the unique selector generation. - Introduced comprehensive tests for data-* attribute handling and selector prioritization.
…eneration - Introduced a new utility function `getPotentialUniqueSelector` to recursively find a unique selector for a given element, considering various selector types and attributes to ignore. - Updated the main `unique` function to utilize the new selector generation logic. - Adjusted tests to reflect changes in expected unique selectors for various elements.
|
|
…nction - Added caching mechanisms for various selector functions (getAttributeSelector, getAttributes, getClasses, getDataAttributes, getID, getName, getNthChild, getTag) to improve performance. - Introduced a new function `getPotentialUniqueSelectors` to recursively find unique selectors for elements, considering multiple attributes and caching for efficiency. - Updated existing functions to utilize caching and handle filters more effectively. - Adjusted tests to validate the new selector generation logic and caching behavior.
|
@estrada9166 Can you sign the CLA? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14