-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(breaking): exclude node_modules from cross-origin-callback-loader #24952
Conversation
Thanks for taking the time to open a PR!
|
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
cy.origin
dependencies within a third-party plugin is no longer supported.Additional details
Previously we were including
node_modules
when scanning forcy.origin
dependencies to ensure any third party plugins/imports would be properly loaded. However, this caused large memory spikes and performance degradation when parsing files with large dependency graphs. Thus, we are going to excludenode_modules
until we can come up with a more optimized solution.Steps to test
The added system test uses a
cy.origin
dependency within anode_modules
plugin and now fails.How has the user experience changed?
cy.origin
dependencies within a third-party plugin will no longer work.PR Tasks
cypress-documentation
?type definitions
?