fix(breaking): exclude node_modules from cross-origin-callback-loader (…

…#24952)

* fix: exclude node_modules from cross-origin-callback-loader

* Update system-tests/test/cy_origin_error_spec.ts

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

* Update system-tests/projects/origin-dependencies/.gitignore

Co-authored-by: Ryan Manuel <ryanm@cypress.io>

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>

npm/webpack-preprocessor/index.ts

@@ -222,7 +222,7 @@ const preprocessor: WebpackPreprocessor = (options: PreprocessorOptions = {}): F
     })
     .tap((opts) => {
       if (opts.devtool === false) {
-        // disable any overrides if we've explictly turned off sourcemaps
+        // disable any overrides if we've explicitly turned off sourcemaps
         overrideSourceMaps(false, options.typescript)
 
         return
@@ -248,6 +248,7 @@ const preprocessor: WebpackPreprocessor = (options: PreprocessorOptions = {}): F
       // so that it's working with plain javascript
       webpackOptions.module.rules.unshift({
         test: /\.(js|ts|jsx|tsx)$/,
+        exclude: /node_modules/,
         use: [{
           loader: require.resolve('@cypress/webpack-preprocessor/dist/lib/cross-origin-callback-loader.js'),
           options: {

packages/driver/src/cypress/error_messages.ts

@@ -1228,7 +1228,9 @@ export default {
 
         Variables must either be defined within the ${cmd('origin')} command or passed in using the args option.
 
-        Using \`require()\` or \`import()\` to include dependencies requires enabling the \`experimentalOriginDependencies\` flag and using the latest version of \`@cypress/webpack-preprocessor\`.`,
+        Using \`require()\` or \`import()\` to include dependencies requires enabling the \`experimentalOriginDependencies\` flag and using the latest version of \`@cypress/webpack-preprocessor\`.
+        
+        Note: Using \`require()\` or \`import()\` within ${cmd('origin')} from a \`node_modules\` plugin is not currently supported.`,
     },
     callback_mixes_sync_and_async: {
       message: stripIndent`\

system-tests/projects/origin-dependencies/.gitignore

@@ -0,0 +1 @@
+!node_modules

system-tests/projects/origin-dependencies/cypress.config.js

@@ -0,0 +1,5 @@
+module.exports = {
+  e2e: {
+    setupNodeEvents (on) {},
+  },
+}

system-tests/projects/origin-dependencies/cypress/e2e/cross_origin.cy.js

@@ -0,0 +1,3 @@
+it('uses custom cy.origin command', () => {
+  cy.customOriginCommand()
+})

system-tests/projects/origin-dependencies/cypress/support/e2e.js

@@ -0,0 +1 @@
+import 'custom-origin-command'

system-tests/test/cy_origin_error_spec.ts

@@ -72,4 +72,18 @@ describe('e2e cy.origin errors', () => {
       expect(res.stdout).to.contain('Using `require()` or `import()` to include dependencies requires enabling the `experimentalOriginDependencies` flag and using the latest version of `@cypress/webpack-preprocessor`')
     },
   })
+
+  systemTests.it('errors when using a plugin that has a custom command that uses cy.origin with a dependency', {
+    browser: '!webkit', // TODO(webkit): cy.origin is not currently supported in webkit
+    project: 'origin-dependencies',
+    spec: 'cross_origin.cy.js',
+    expectedExitCode: 1,
+    config: commonConfig,
+    async onRun (exec) {
+      const res = await exec()
+
+      expect(res.stdout).to.contain('Using `require()` or `import()` to include dependencies requires enabling the `experimentalOriginDependencies` flag and using the latest version of `@cypress/webpack-preprocessor`')
+      expect(res.stdout).to.contain('Note: Using `require()` or `import()` within `cy.origin()` from a `node_modules` plugin is not currently supported.')
+    },
+  })
 })