Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cypress",
"version": "9.7.0",
"version": "9.7.1",
"description": "Cypress.io end to end testing tool",
"private": true,
"scripts": {
Expand Down
6 changes: 2 additions & 4 deletions packages/server/lib/browsers/electron.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ const _getAutomation = async function (win, options, parent) {
if (message !== 'take:screenshot') {
return fn(message, data)
}

await sendCommand('Page.startScreencast', screencastOpts)
await sendCommand('Page.startScreencast', screencastOpts())

const ret = await fn(message, data)

Expand Down Expand Up @@ -103,15 +102,14 @@ const _maybeRecordVideo = function (webContents, options) {
if (!onScreencastFrame) {
return
}

webContents.debugger.on('message', (event, method, params) => {
if (method === 'Page.screencastFrame') {
onScreencastFrame(params)
webContents.debugger.sendCommand('Page.screencastFrameAck', { sessionId: params.sessionId })
}
})

await webContents.debugger.sendCommand('Page.startScreencast', screencastOpts)
await webContents.debugger.sendCommand('Page.startScreencast', screencastOpts())
}
}

Expand Down
2 changes: 2 additions & 0 deletions packages/server/lib/modes/record.js
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,8 @@ const createRunAndRecordSpecs = (options = {}) => {
})

if (response === responseDidFail) {
debug('`responseDidFail` equals `response`, allowing browser to hang until it is killed: Response %o', { responseDidFail })

// dont call the cb, let the browser hang until it's killed
return
}
Expand Down