Skip to content

Conversation

@htekdev
Copy link

@htekdev htekdev commented Aug 13, 2022

  • Closes

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@htekdev htekdev requested a review from a team as a code owner August 13, 2022 20:12
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 13, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2022

CLA assistant check
All committers have signed the CLA.

@htekdev htekdev changed the title fix: call screencastOpts as a function for starting a screencast on e… Cherry pick for needed fix in 9.x Aug 13, 2022
@htekdev htekdev changed the title Cherry pick for needed fix in 9.x fix: call screencastOpts as a function for starting a screencast on electron Aug 15, 2022
Copy link
Contributor

@mjhenkes mjhenkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't traditionally done patch fixes on prior major versions of Cypress. We'll need to discuss internally if/how we want to approach this. Marking this PR as Request changes to ensure it isn't merged until we're ready.

@marktnoonan marktnoonan removed their request for review August 15, 2022 14:08
@emilyrohrbough
Copy link
Member

@htekdev At this time, we are not interested in creating a patch release for 9.x. Historically we have not done patch releases for previous major versions. This isn't to say we wouldn't consider it in the future, but at this time we will make that call on a case-by-case basis.

Is there a reason you are unable to update to Cypress 10.0 where this issue might be fixed and/or this change could be applied there?

@nagash77
Copy link
Contributor

@htekdev We haven't heard from you in awhile so I am going to close this PR. We would love to hear more about why you are unable to upgrade your Cypress to the latest version, so please do respond to this ticket if you can. If there are blockers we would like to understand what they are.

@nagash77 nagash77 closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants