Skip to content

Conversation

@tgriesser
Copy link
Member

Looks like this got accidentally re-added in merge commit here: 76129e2#diff-92fadee1dfb23b20d6b0f6557a3ea0b8a231a7591db73f9f37772383bd0575d9R56

This is no longer used and has typescript as a dependency, which we no longer want to have bundled in the binary

@tgriesser tgriesser requested a review from a team as a code owner April 4, 2022 23:55
@tgriesser tgriesser requested review from benpatterson and removed request for a team April 4, 2022 23:55
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 4, 2022

Thanks for taking the time to open a PR!

@tgriesser tgriesser requested review from lmiller1990 and removed request for benpatterson April 4, 2022 23:55
@cypress
Copy link

cypress bot commented Apr 5, 2022



Test summary

17792 0 217 0Flakiness 1


Run details

Project cypress
Status Passed
Commit 1480d64
Started Apr 5, 2022 12:08 AM
Ended Apr 5, 2022 12:20 AM
Duration 12:18 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/navigation.cy.js Flakiness
1 src/cy/commands/navigation > #visit > window immediately resolves and doesn't reload when visiting the same URL with hashes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tgriesser tgriesser merged commit 2909c93 into 10.0-release Apr 5, 2022
@tgriesser tgriesser deleted the tgriesser/chore/remove-dependency-tree branch April 5, 2022 13:55
tgriesser added a commit that referenced this pull request Apr 5, 2022
* 10.0-release:
  chore: remove dependency-tree dep (#20905)
tgriesser added a commit that referenced this pull request Apr 5, 2022
* 10.0-release: (92 commits)
  chore: remove dependency-tree dep (#20905)
  chore(launchpad): work on infra for scaffold tests (#20818)
  fix: build mjs in the cli (#20889)
  fix(unify): Cypress version link should point to Cypress doc's changelog (#20869)
  fix: windows build (#20854)
  fix: add index.mjs to the published files of cli (#20884)
  refactor: lift indexHtmlFile up to component, add validation (#20870)
  fix: allow migration of pluginsFile using `env` properties (#20770)
  fix: viewport from CLI on CT (#20849)
  Don't communicate if process isn't connected
  Remove config.get
  Update packages/data-context/src/data/ProjectLifecycleManager.ts
  fix: git data source unit test failure (#20875)
  add comment for autoBindDebug
  fix: Ensuring current browser is synchronized between app and launchpad (#20830)
  Fix missed await on merge conflict resolution
  test(unification): move record keys to contexts (#20860)
  test: move record keys to contexts (#20859)
  PR comments
  Fix tests that visit app without a configured testing type
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants