fix: viewport from CLI on CT #20849
Merged
fix: viewport from CLI on CT #20849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrada9166
requested review from
jennifer-shehane
and removed request for
a team
Contributor
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
lmiller1990
reviewed
Mar 30, 2022
Contributor
lmiller1990
left a comment
lmiller1990
left a comment
There was a problem hiding this comment.
One comment around types
| }, { | ||
| name: 'viewportWidth', | ||
| defaultValue: 1000, | ||
| defaultValue: (options: Record<string, any> = {}) => options.testingType === 'component' ? 500 : 1000, |
Contributor
There was a problem hiding this comment.
Should this be options: Cypress.Config?
Member
Author
There was a problem hiding this comment.
I'm not sure if it should be Cypress.Config because it comes from here which is when we are building the config in runtime
lmiller1990
approved these changes
Apr 1, 2022
Contributor
davidmunechika
approved these changes
Apr 1, 2022
tgriesser
added a commit
that referenced
this pull request
Apr 1, 2022
* 10.0-release: fix: add index.mjs to the published files of cli (#20884) refactor: lift indexHtmlFile up to component, add validation (#20870) fix: allow migration of pluginsFile using `env` properties (#20770) fix: viewport from CLI on CT (#20849) fix: git data source unit test failure (#20875) fix: Ensuring current browser is synchronized between app and launchpad (#20830) Fix missed await on merge conflict resolution test(unification): move record keys to contexts (#20860) test: move record keys to contexts (#20859) make alerts more responsive chore: Update Chrome (stable) to 100.0.4896.60 (#20841) Revise test. fix: cy.root respect timeout option. fix(deps): update dependency ansi-regex to v4.1.1 [security] (#20836) chore(deps): update dependency ansi-regex to 4.1.1 [security] (#20807) chore: Refactor cri-client to use async/await (#20825) remove automationId from runnerStore fix firefox automation and adress feedback feat: add automation warning/disconnected states in app
tgriesser
added a commit
that referenced
this pull request
Apr 1, 2022
…ess into tgriesser/fix/UNIFY-1389 * 'tgriesser/fix/UNIFY-1389' of github.com:cypress-io/cypress: (56 commits) fix: add index.mjs to the published files of cli (#20884) refactor: lift indexHtmlFile up to component, add validation (#20870) fix: allow migration of pluginsFile using `env` properties (#20770) fix: viewport from CLI on CT (#20849) Don't communicate if process isn't connected Remove config.get Update packages/data-context/src/data/ProjectLifecycleManager.ts fix: git data source unit test failure (#20875) add comment for autoBindDebug PR comments Fix tests that visit app without a configured testing type Fix type script Fix issue with refreshing on the welcome screen Add test for migration scenario Fix types Move IPC logic to all be in ProjectConfigIPC Other minor cleanup Additional code cleanup Fix more tests Fix typo ...
tgriesser
added a commit
that referenced
this pull request
Apr 5, 2022
* 10.0-release: (92 commits) chore: remove dependency-tree dep (#20905) chore(launchpad): work on infra for scaffold tests (#20818) fix: build mjs in the cli (#20889) fix(unify): Cypress version link should point to Cypress doc's changelog (#20869) fix: windows build (#20854) fix: add index.mjs to the published files of cli (#20884) refactor: lift indexHtmlFile up to component, add validation (#20870) fix: allow migration of pluginsFile using `env` properties (#20770) fix: viewport from CLI on CT (#20849) Don't communicate if process isn't connected Remove config.get Update packages/data-context/src/data/ProjectLifecycleManager.ts fix: git data source unit test failure (#20875) add comment for autoBindDebug fix: Ensuring current browser is synchronized between app and launchpad (#20830) Fix missed await on merge conflict resolution test(unification): move record keys to contexts (#20860) test: move record keys to contexts (#20859) PR comments Fix tests that visit app without a configured testing type ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
Fix viewport config params pass through CLI for CT - currently the usage of
--config viewportWidth=333,viewportHeight=333was not working for CT because it was being overridden in a config update; it was working fine for e2e testsHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?