Skip to content

Conversation

@davidmunechika
Copy link
Contributor

@davidmunechika davidmunechika commented Oct 12, 2021

User facing changelog

Users can pass overwrite: true option to Cypress.Screenshot.defaults to change default behavior to overwrite existing screenshots without having to set overwrite for each cy.screenshot command.

Additional details

The support for this feature was actually added in the previous PR: #18280 , but this PR adds the default setting for the option to false and adds an additional test to specifically focus on this usage (the documentation also needs to be updated to reflect support for this feature).

PR Tasks

@cypress-io cypress-io deleted a comment from cypress-bot bot Oct 12, 2021
@cypress-io cypress-io deleted a comment from cypress bot Oct 12, 2021
@cypress
Copy link

cypress bot commented Oct 12, 2021



Test summary

18552 0 214 7Flakiness 2


Run details

Project cypress
Status Passed
Commit 2b2ae17
Started Oct 13, 2021 3:51 PM
Ended Oct 13, 2021 4:05 PM
Duration 13:18 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
settings_spec.js Flakiness
1 Settings > file preference panel > loads preferred editor and available editors

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@davidmunechika davidmunechika marked this pull request as ready for review October 13, 2021 15:47
@davidmunechika davidmunechika requested a review from a team as a code owner October 13, 2021 15:47
@davidmunechika davidmunechika requested review from BlueWinds and emilyrohrbough and removed request for a team October 13, 2021 15:47
Copy link
Contributor

@BlueWinds BlueWinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@davidmunechika davidmunechika merged commit bc21574 into develop Oct 13, 2021
@davidmunechika davidmunechika deleted the issue-7955-default-overwrite-existing-screenshots branch October 13, 2021 17:34
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2021

Released in 8.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants