feat(driver): Add "overwrite" option to cy.screenshot() #18280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
davidmunechika
requested review from
chrisbreiding and
flotwig
and removed request for
a team
flotwig
suggested changes
Sep 29, 2021
Contributor
flotwig
left a comment
flotwig
left a comment
There was a problem hiding this comment.
looks good, but I think the test could be stricter
packages/server/test/support/fixtures/projects/e2e/cypress/integration/screenshots_spec.js
Show resolved
Hide resolved
packages/server/test/support/fixtures/projects/e2e/cypress/integration/screenshots_spec.js
Show resolved
Hide resolved
Co-authored-by: Zach Bloomquist <github@chary.us>
Co-authored-by: Zach Bloomquist <github@chary.us>
Co-authored-by: Zach Bloomquist <github@chary.us>
chrisbreiding
requested changes
Sep 30, 2021
Contributor
chrisbreiding
left a comment
chrisbreiding
left a comment
There was a problem hiding this comment.
Just requested a couple small changes, but otherwise looks great.
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
chrisbreiding
approved these changes
Sep 30, 2021
davidmunechika
deleted the
issue-7955-overwrite-existing-screenshots
branch
tgriesser
added a commit
that referenced
this pull request
Oct 8, 2021
* develop: (31 commits) fix: `everyNthFrame` should only be applied for Chrome 89+ (#18392) docs: General updates to contributing guide (#18283) chore: Update Chrome (beta) to 95.0.4638.40 (#18389) chore: use circleci timings split for e2e tests (#18367) fix: fixed title (#18370) chore(deps): update dependency electron to v14 🌟 (#18384) chore(server): share client route (#18215) fix: Prevent Cypress from crashing when argument parsing "spec: {}" (#18312) chore: update husky dev dependency to v7 (#18345) feat: add defineConfig function to help type config (#18302) chore: Update Chrome (stable) to 94.0.4606.71 (#18324) feat: allow to use TypeScript in the config file (#18300) allow select to be called with empty array (#18329) fix(vite-dev-server): windows `supportFile` + preserve optimize entries (#18286) chore: fix semantic-release dry run (#18332) fix(driver): improve status_code_flags_invalid error message (#18316) chore(deps): update dependency electron to v13.5.0 🌟 (#18318) chore: Update Chrome (stable) to 94.0.4606.61 and Chrome (beta) to 95.0.4638.32 (#18229) fix(proxy-logging): use constant consoleProps object (#18207) feat(driver): Add "overwrite" option to cy.screenshot() (#18280) ...
5 tasks
mjhenkes
pushed a commit
that referenced
this pull request
Jul 27, 2022
Co-authored-by: Zach Bloomquist <github@chary.us> Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Users can pass
overwrite: trueas an option tocy.screenshot()to overwrite existing screenshots with the same file name.Additional details
When
overwriteisfalse(by default), the screenshots append a number at the end of each screenshot taken with the same name as an existing screenshot.When
overwriteis set totrue, the new screenshot will overwrite an existing screenshot with the same file name.PR Tasks
cypress-documentation? Add "overwrite" option to cy.screenshot() cypress-documentation#4122type definitions?cypress.schema.json? --> N/A