Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-start-up.md:- Corrects a few grammatical errors #1692

Merged
merged 1 commit into from
May 25, 2020
Merged

Update controller-start-up.md:- Corrects a few grammatical errors #1692

merged 1 commit into from
May 25, 2020

Conversation

PRUBHTEJ
Copy link
Contributor

@PRUBHTEJ PRUBHTEJ commented May 23, 2020

Description
A few grammatical errors are committed in the documentation, which are corrected by this PR.

Tasks
Add the list of tasks of this PR.

  • This PR corrects a few grammatical errors in the documentation.

Documentation
https://cyberbotics.com/doc/guide/controller-start-up

@PRUBHTEJ PRUBHTEJ added the documentation Improve or fix the documentation (MD files only, no software development) label May 23, 2020
@PRUBHTEJ PRUBHTEJ requested a review from DavidMansolino May 23, 2020 17:33
@PRUBHTEJ PRUBHTEJ self-assigned this May 23, 2020
@PRUBHTEJ PRUBHTEJ requested a review from omichel May 24, 2020 18:06
Copy link
Member

@DavidMansolino DavidMansolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@PRUBHTEJ
Copy link
Contributor Author

Thank you.

Needless, Sir.

@PRUBHTEJ PRUBHTEJ merged commit 4f67f02 into cyberbotics:master May 25, 2020
@@ -2,10 +2,10 @@

The .wbt file contains the name of the controller that needs to be started for each robot.
The controller name is a platform and language independent field; for example when a controller name is specified as "xyz\_controller" in the .wbt file, this does not say anything about the controller's programming language or platform.
This is done deliberately to ensure the platform and programming language independence of .wbt files.
This is done deliberately to ensure the independence between platform and programming language of .wbt files.
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this change is correct?
Because in the new sentence to me it seems that platform and programming languages should be independent from each other.
But are WBT files that are independent from the platform and they are independent from the programming language used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds wrong to me as well...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PRUBHTEJ: can you propose a rephrasing for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omichel , @stefaniapedrazzi I'll try to rephrase it as soon as possible .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve or fix the documentation (MD files only, no software development)
Development

Successfully merging this pull request may close these issues.

4 participants