Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conjur CLI v8.0 #183

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Use Conjur CLI v8.0 #183

merged 1 commit into from
Mar 15, 2023

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 9, 2023

Desired Outcome

Update scripts to use Conjur CLI v8.0.

Implemented Changes

  • Updated 2_prepare_docker_images.sh script to use version 8 of the Conjur CLI image.
  • Update CLI commands to use new syntax
  • Add new test-curl pod to test master readiness since the new cli container doesn't contain curl
  • Remove support for Conjur v4 in all scripts

Connected Issue/Story

CyberArk internal issue ID: ONYX-33379

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Mar 9, 2023
@szh szh force-pushed the cli8 branch 17 times, most recently from a6383f8 to d5544bd Compare March 9, 2023 21:31
@szh szh marked this pull request as ready for review March 9, 2023 21:59
@szh szh requested a review from a team as a code owner March 9, 2023 21:59
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but I wonder if we should prepare updates to conjur-authn-k8s-client and secrets-provider-for-k8s scripts before merging. I believe they point to the main branch of this repo for dev environments and e2e tests and still use the old CLI syntax.

@szh
Copy link
Contributor Author

szh commented Mar 14, 2023

cyberark/secrets-provider-for-k8s#505 is ready

@szh
Copy link
Contributor Author

szh commented Mar 14, 2023

cyberark/conjur-authn-k8s-client#505 is mostly ready. Still trying to debug a failure in the Jenkins E2E test.

@szh
Copy link
Contributor Author

szh commented Mar 15, 2023

OK, those are ready now which should unblock this. Can you please approve @gl-johnson?

@szh szh merged commit b95735f into master Mar 15, 2023
@szh szh deleted the cli8 branch March 15, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants