Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conjur CLI v8.0 #149

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Use Conjur CLI v8.0 #149

merged 1 commit into from
Mar 17, 2023

Conversation

szh
Copy link
Contributor

@szh szh commented Feb 23, 2023

Desired Outcome

Update demo to use CLI v8.0.

Implemented Changes

Connected Issue/Story

CyberArk internal issue ID: ONYX-33379

Depends on cyberark/kubernetes-conjur-deploy#183

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh force-pushed the cli8 branch 6 times, most recently from de04267 to 88bb400 Compare March 9, 2023 14:16
@szh szh self-assigned this Mar 9, 2023
@szh szh force-pushed the cli8 branch 16 times, most recently from 86b68a7 to ddcb1b0 Compare March 15, 2023 20:49
@szh szh marked this pull request as ready for review March 15, 2023 20:49
Copy link
Collaborator

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@szh szh merged commit 4a7504e into main Mar 17, 2023
@szh szh deleted the cli8 branch March 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants