chore: migrate to new llamalend library #915
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DanielSchiavini
commented
May 7, 2025
•
DanielSchiavini
commented
- Migrate lend and crvusd apps to use @curvefi/llamalend-js instead of @curvefi/lending-js and @curvefi/stablecoin-js
- Reapplies feat: llamalend js #790 and feat: llamalend js #886
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DanielSchiavini
commented
May 7, 2025
| export type NetworkEnum = INetworkName | ||
| export type Provider = ethers.BrowserProvider | ||
| export type MarketListType = 'borrow' | 'supply' | ||
| export type EstimatedGas = number | number[] | null | ||
| export type OneWayMarketTemplate = LendMarketTemplate // todo: use LendMarketTemplate consistently |
There was a problem hiding this comment.
Separate PR to make it easier to review
DanielSchiavini
force-pushed
the
feat/llamalend-js
branch
from
cdccf55 to
5c94017
Compare
|
Do not merge yet: There's been a bug spotted in stablecoin api where new mint markets are incorrectly using the isEth parameter when calling remove_collateral. The same fix also needs to be applied to llamalend api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.