-
Notifications
You must be signed in to change notification settings - Fork 33
feat: llamalend js #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: llamalend js #790
Conversation
…-frontend into feat/llamalend-js
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…end into feat/llamalend-js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the lend and crvusd applications to use the new @curvefi/llamalend-js API instead of the previous lending and stablecoin APIs. Key changes include:
- Replacing OneWayMarketTemplate with LendMarketTemplate and updating associated types in multiple components.
- Switching API references from the old Api to LlamalendApi and adjusting state hook keys (e.g. isLoadingLending → isLoadingLlamalend).
- Updating comments and minor utility tweaks (e.g. refresh rate handling in background.ts) to align with the new llama-based API.
Reviewed Changes
Copilot reviewed 112 out of 113 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
apps/main/src/lend/components/PageMarketList/utils.ts | Updated market type and mapper types from OneWayMarketTemplate to LendMarketTemplate |
apps/main/src/lend/components/PageMarketList/types.ts | Updated type definitions to use LendMarketTemplate and LlamalendApi |
apps/main/src/lend/components/PageMarketList/Page.tsx | Adjusted API hook usage to reference isLoadingLlamalend |
apps/main/src/lend/components/PageLoanManage/* | Replaced OneWayMarketTemplate and Api with LendMarketTemplate and LlamalendApi across multiple loan management files |
apps/main/src/lend/components/PageLoanCreate/* | Updated market and API types in loan creation components to match llamalend changes |
apps/main/src/ background.ts | Modified refresh timeout logic based on NODE_ENV for development versus production |
apps/main/src/app/crvusd/client.tsx | Changed API store references from stable to llamalend for USD rate and gas info fetching |
Files not reviewed (1)
- apps/main/package.json: Language not supported
Comments suppressed due to low confidence (1)
apps/main/src/background.ts:5
- [nitpick] The comment indicates a lower refresh rate during development, yet '60 * minute' sets a longer interval; consider rephrasing the comment to clarify that refreshes are intentionally less frequent in development.
const RefreshTimeoutMs = process.env.NODE_ENV === 'development' ? 60 * minute : minute
fix: storybook version conflict
Depends on feat: dudupe advanced settings and MUI-ify #777 and refactor: api store #783