Simplify default iteration scopes; file scopeHandler #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
commented
Oct 23, 2022
|
|
||
| export default class DocumentScopeHandler implements ScopeHandler { | ||
| public readonly scopeType = { type: "line" } as const; | ||
| public readonly iterationScopeType = { type: "document" } as const; |
There was a problem hiding this comment.
Note that iteration scope of document is document, so we get "every file" for free, if for whatever reason someone wants to do that 🤔
pokey
commented
Oct 23, 2022
| * might want the default iteration scope to be `"file"`, but you don't need | ||
| * to expand to the file just to find instances of the given scope type. | ||
| */ | ||
| protected get searchScopeType(): ScopeType { |
There was a problem hiding this comment.
I added this in preparation for "next air" / "every air", which will use line as its search scope, but document as its iteration scope
pokey
commented
Oct 23, 2022
Comment on lines
-150
to
-155
| if (fixture.thrownError != null) { | ||
| throw Error( | ||
| `Expected error ${fixture.thrownError.name} but none was thrown` | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Needed to move this so that we could update fixtures that went from error to success
2 tasks
src/processTargets/modifiers/scopeHandlers/DocumentScopeHandler.ts
Outdated
Show resolved
Hide resolved
pokey
commented
Oct 23, 2022
src/processTargets/modifiers/scopeHandlers/DocumentScopeHandler.ts
Outdated
Show resolved
Hide resolved
AndreasArvidsson
approved these changes
Oct 24, 2022
AndreasArvidsson
deleted the
pokey/simplify-default-iteration-scopes-file-scopehandler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes notion of
getIterationScopesTouchingPositionand instead just calls containing scope on iteration scopeAlso steals
DocumentScopeHandlerfrom #1073 as that was necessary to make line scope handler work in this new setupChecklist