Migrating scope stages into handlers #1073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasArvidsson
changed the title
pokey
reviewed
Oct 23, 2022
| @@ -12,7 +12,7 @@ export default class LineScopeHandler implements ScopeHandler { | |||
| public readonly iterationScopeType = { type: "document" } as const; | |||
|
|
|||
| constructor( | |||
| public readonly scopeType: { type: "line" }, | |||
| public readonly scopeType: ScopeType, | |||
There was a problem hiding this comment.
I'm thinking of using this type information for generating our docs. Do you mind if we leave it?
There was a problem hiding this comment.
Why not turn it into a proper type instead? I mean in the types file we have made them all SimpleScopeType if we actually want to have it more fine grain I think we should do it at that end so we don't have to do casts when calling the constructor.
public readonly scopeType: LineScopeType
There was a problem hiding this comment.
Why would giving it a name allow us to avoid casts?
2 tasks
|
Folded into #1075 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1054
Checklist