Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "autonag" application #7

Open
3 tasks
rjw57 opened this issue Jul 12, 2016 · 8 comments
Open
3 tasks

Create "autonag" application #7

rjw57 opened this issue Jul 12, 2016 · 8 comments
Assignees
Milestone

Comments

@rjw57
Copy link
Member

rjw57 commented Jul 12, 2016

The autonag application provides a management command which will run daily and send the "autonag" emails. The command should be idempotent in that running it repeatedly will net affect the frequency of emails sent.

Tasks:

  • Create autonag application
  • Create autonag management command
  • Add "new member" nag

We can add more nags as other parts of the software are implemented.

@rjw57 rjw57 self-assigned this Jul 12, 2016
@rjw57 rjw57 added this to the MVP milestone Jul 12, 2016
@rjw57 rjw57 changed the title Creates "autonag" application Create "autonag" application Jul 12, 2016
rjw57 added a commit to rjw57/edpcmentoring that referenced this issue Jul 12, 2016
This is a stub application created by the "startapp" management command.

See cuedpc#7
This was referenced Jul 12, 2016
@S-Stephen
Copy link
Contributor

I see at the moment the notification emails are recorded into the Email log->Emails table, unless something like settings PINAX_NOTIFICATIONS_BACKENDS=[("email", "pinax.notifications.backends.email.EmailBackend"),] is set.

Is the intention to continue to create the messages in this table then run a scheduler to send the messages later, during the night?

Another scheduler will be required to populate the email table with the nags eg you have not had any meeting with X for Y weeks etc.

@rjw57
Copy link
Member Author

rjw57 commented Feb 14, 2017 via email

@S-Stephen
Copy link
Contributor

I think that it would be useful for the notification to be sent immediately in some cases for example:

  • when a users registers a meeting, to avoid the other party adding the same meeting
  • when a user sends or accepts an invite

However it would also be nice to have a log of these notifications, which if just sending immediately I don't think happens automatically.

For the periodic reminders then yes dong these in bulk at a particular time I think could would be helpful.

I'm slightly split, and I'm not sure if I found a clear way to dictate from the 'send()' which route a message would take (direct or via Email log).

@rjw57
Copy link
Member Author

rjw57 commented Feb 14, 2017 via email

@S-Stephen
Copy link
Contributor

Celery looks as though it logs and capture issues. Also need to find out if it can be used to temporarily disable email.

I'll take a look at Celery (http://celery.readthedocs.io) in branch REST-Celery.

(Unless there are know issues or other leads)

@S-Stephen
Copy link
Contributor

Having taken a look it seems as though using mysql as the broker for Celery isn't a good idea. They suggest RabbitMQ or Redis though to install either on MWS requires a fair amount of work.

S-Stephen added a commit that referenced this issue Feb 16, 2017
…n mws3 setup, added array of admin contacts in case sendingn fails
@S-Stephen
Copy link
Contributor

I've used the pinax-notifications emit_notices management command. Happy to write a specific one for autonag but wasn't too sure what else it should do other than send messages and check for exceptions.

@S-Stephen
Copy link
Contributor

What should happen with new member nag?

On loading a new user -> are they to get a 'congratulations' message?

Can we create another management command to search for things to nag and create the notifications (and for now keep the logic in the code; how many nags are there?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants