Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve be_a_command_found_in_path matcher and its tests #895

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jan 22, 2023

Summary

Improve be_a_command_found_in_path matcher and its tests

Details

  • Test all behavior in the specs
  • Leave simple scenario as documentation
  • Simplify implementation
  • Render correct path in failure message

Motivation and Context

This was extracted from #799.

How Has This Been Tested?

Specs were added.

Types of changes

  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code

* Test all behavior in the specs
* Leave simple scenario as documentation
* Simplify implementation
* Render correct path in failure message
@mvz mvz force-pushed the improve-be-a-command-found-in-path branch from 08d0e89 to a2ddad0 Compare January 22, 2023 15:19
@mvz mvz merged commit e727e6e into main Jan 22, 2023
@mvz mvz deleted the improve-be-a-command-found-in-path branch January 22, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant