Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run cucumber scenarios on Windows #799

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Run cucumber scenarios on Windows #799

wants to merge 30 commits into from

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Apr 5, 2021

Summary

Run cucumber scenarios on Windows and make them pass

Details

  • Enable cucumber scenarios on Windows in GitHub Actions
  • Fix scenarios so they pass

Motivation and Context

Use of Aruba on Windows should be fully tested.

How Has This Been Tested?

In CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz mvz force-pushed the cukes-on-windows branch 6 times, most recently from 7d179e8 to 3a9766a Compare June 21, 2021 06:44
This was referenced Jan 22, 2023
Draft
Merged
mvz and others added 18 commits March 17, 2024 15:21
@mvz
Run cucumber scenarios on Windows
09deb34
@mvz
Temporarily limit set of platforms
8609a39
@mvz
Add bat runner for default test cli app
8546717
@mvz
Use default executable instead of specifying another
e24ae23
@xtrasimplicity @mvz
CI: Skip scenarios with @requires-bash unless bash is installed.
e9482b2
@mvz
Provide separate scenarios for Windows and Unix for be_a_command_foun…
a008134 
…d_in_path
@mvz
Make check_timeouts feature cross-platform
e0e6a71 
* Use existing commands instead of non-portable bash scripts
* Use timeout command if sleep is not available
@mvz
Silence warnings about ansicon
24c5791
@xtrasimplicity @mvz
Started adding unpublished windows-specific features.
56b2aa7
@xtrasimplicity @mvz
CI: Windows - Fixed CleanUpWorkingDirectory feature.
8fb12e7
@xtrasimplicity @mvz
Fixed usage of .cucumberproignore file.
b2e16b0
@xtrasimplicity @mvz
CI: Windows - Fixed 01\getting_started\RunCommands feature.
0912818
@xtrasimplicity @mvz
CI: Windows - Fixed supported_testing_frameworks.feature
69c3f21
@xtrasimplicity @mvz
Add @requires-sleep hook
5de3245
@xtrasimplicity @mvz
CI: Windows - Fixed 02_ConfiguringAruba\CommandRuntimeEnvironment.fea…
7310875 
…ture
@xtrasimplicity @mvz
CI: Windows - Skip Exit timeout config. Added ToDo.
6066090
@xtrasimplicity @mvz
CI: Windows - Fixed 02_Configuring_Aruba\HomeDirectory feature.
d4597f9
@xtrasimplicity @mvz
CI: Windows - Fixed 03\testing_frameworks\cucumber\announce_...
371ab51
xtrasimplicity and others added 12 commits March 17, 2024 15:28
@xtrasimplicity @mvz
CI: Windows - Fixed disabling bundler feature.
82a6b4a
@xtrasimplicity @mvz
CI: Windows - Fix define_after_hook_for_commands feature.
ac9da29
@xtrasimplicity @mvz
CI: Windows - Fix define_before_hook_for_commands feature. (Cucumber)
97cf8c5
@xtrasimplicity @mvz
CI: Windows - Fixed check_for_exit_status feature (Cucumber)
1a72ba1
@mvz
Mark Windows-only version of Cleanup Working Directory feature as such
9bb1675
@mvz
Windows: Fix getting started with aruba/run commands feature
541c15e
@mvz
Windows: Unify announce_information_for_troubleshooting feature
2f85128
@mvz
Windows: Unify check_for_exit_statuses feature
e0b58cf
@mvz
Make check_output_of_command feature platform independent
c3cb0f3 
- Do not use bash scripts
- Directly run echo or ruby where possible
- Move large output edge case to spec
@mvz
Make 02_configure_aruba/basics feature platform-independent
9813e43
@mvz
Remove edge-case scenario
664fb31
@mvz
Re-organize and improve output check scenarios
2a1c5ba 
- Move scenarios for checking success + output to a separate feature
- Unify order and implementation of scenarios for checking output,
  stderr and stdout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: work in progress windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @xtrasimplicity