Add step and API to add whole lines to a file #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
issue-662-add-append-lines-functionality
branch
from
607f376
to
50bc4c1
Compare
| @@ -26,6 +26,28 @@ Feature: Append content to file | |||
| When I run `cucumber` | |||
| Then the features should all pass | |||
|
|
|||
| Scenario: Append whole lines to a existing file | |||
olleolleolle
approved these changes
Jan 24, 2021
Due to how multi-line string literals work in Gherkin, it is easy to accidentally have fewer newlines than intended when building up a file using append_to_file. To mitigate this while still allowing building up files without inserted newlines, this change introduces a new API method #append_lines_to_file and a corresponding step definition, that will ensure a newline is present between the original content and the added content.
mvz
force-pushed
the
issue-662-add-append-lines-functionality
branch
from
50bc4c1
to
ac69b3e
Compare
olleolleolle
approved these changes
Jan 24, 2021
luke-hill
approved these changes
Jan 25, 2021
spec/aruba/api/filesystem_spec.rb
Outdated
| @@ -4,6 +4,23 @@ | |||
| RSpec.describe Aruba::Api::Filesystem do | |||
| include_context "uses aruba API" | |||
|
|
|||
| describe "#append_lines_to_file" do | |||
| let(:path) { @file_path } | |||
There was a problem hiding this comment.
pop these as top level? Seem to be used in nearly all of the examples (I scrolled down past L40)
mvz
force-pushed
the
issue-662-add-append-lines-functionality
branch
from
adef003
to
99e13be
Compare
mvz
force-pushed
the
issue-662-add-append-lines-functionality
branch
from
99e13be
to
6b65b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add step and API to add whole lines to a file
Details
Due to how multi-line string literals work in Gherkin, it is easy to accidentally have fewer newlines than intended when building up a file using append_to_file.
To mitigate this while still allowing building up files without inserted newlines, this change introduces a new API method
#append_lines_to_fileand a corresponding step definition, that will ensure a newline is present between the original content and the added content.Motivation and Context
Fixes #662.
How Has This Been Tested?
A new Cucumber scenario and RSpec specs were added.
Types of changes
Checklist: