Do not replace entire environment inside cd block #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport fix for
cdbehavior.Details
Test and fix the the setting of environment variables inside the block passed to
cd. Backport of cbbefda, which was part of #442.Motivation and Context
The
#cdmethod would clear the entire environment within the block, instead of just updating it. This is clearly not the intended behavior, since even variables set withset_environment_variableare ignored. This also makes#cda bad substitute for the deprecated#in_current_directorymethod.How Has This Been Tested?
Specs were added.
Types of changes
Checklist: