Fix environment handling #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensures HOME and PATH are set early enough to have effect - Ensures environment is amended rather than replaced
Merged
|
@mvz I forgot why I implemented it with |
|
🎉 |
This was referenced Mar 15, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve handling of environment. In particular, makes
ENV['HOME']have a correct and safe value.This PR depends on #441 so needs to be rebased after that PR has been merged.Motivation and Details
The main purpose is to make all the current specs pass. It does this by changing the environment setup in the specs, so that:
This change also fixes the
#cdmethod to not clear the entire environment inside the block.After this PR has been merged we can revisit #434 and concentrate on the cucumber scenarios there.