-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make FakeKernel#exit behave like real Kernel#exit #594
Conversation
3b5602c
to
3d9f1d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, @grosser!
fixed up! |
3d9f1d8
to
46ac5b8
Compare
46ac5b8
to
1df1a2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks legit!
Then merge it 😄
…On Sun, Feb 17, 2019, 12:39 Olle Jonsson ***@***.*** wrote:
***@***.**** approved this pull request.
This looks legit!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#594 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ5uvlTpiV47XN7L1lLOunXdb5nTNks5vOb4agaJpZM4a8ePq>
.
|
Hi @grosser, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Yes! And done! |
thx for the invite, I'm not really a cucumber user though, just hunting
down a rabbit hole I found :D
…On Sun, Feb 17, 2019 at 1:10 PM Olle Jonsson ***@***.***> wrote:
Yes! And done!
|
fixes #592
@olleolleolle