Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make FakeKernel#exit behave like real Kernel#exit #594

Merged
merged 1 commit into from
Feb 17, 2019

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Feb 14, 2019

@grosser grosser force-pushed the grosser/fake branch 2 times, most recently from 3b5602c to 3d9f1d8 Compare February 14, 2019 21:33
@mvz mvz self-assigned this Feb 17, 2019
Copy link
Contributor

@mvz mvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, @grosser!

lib/aruba/processes/in_process.rb Show resolved Hide resolved
spec/aruba/processes/in_process_spec.rb Outdated Show resolved Hide resolved
spec/aruba/processes/in_process_spec.rb Outdated Show resolved Hide resolved
@grosser
Copy link
Contributor Author

grosser commented Feb 17, 2019

fixed up!

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks legit!

@grosser
Copy link
Contributor Author

grosser commented Feb 17, 2019 via email

@olleolleolle olleolleolle merged commit f198b36 into cucumber:master Feb 17, 2019
@aslakhellesoy
Copy link
Contributor

Hi @grosser,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@olleolleolle
Copy link
Contributor

Yes! And done!

♥️ 💛 💚 💙 💜

@grosser
Copy link
Contributor Author

grosser commented Feb 17, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exit false should result in exit_status 1
4 participants