Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit false should result in exit_status 1 #592

Closed
grosser opened this issue Feb 14, 2019 · 1 comment · Fixed by #594
Closed

exit false should result in exit_status 1 #592

grosser opened this issue Feb 14, 2019 · 1 comment · Fixed by #594

Comments

@grosser
Copy link
Contributor

grosser commented Feb 14, 2019

When using Aruba::Processes::InProcess FakeKernel#exit does not translate false to 1, which results in Then(/^the exit status should( not)? be (\d+)$/) from lib/aruba/cucumber/command.rb to fail with has exit status of "1", but has "false"

ruby -e 'exit false'
echo $?
1

so FakeKernel needs a fix ... I can do the PR if that sounds right.

@olleolleolle
Copy link
Contributor

That does sound right to me. A Ruby behavioural compatibility improvement to FakeKernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants