Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command spawning when spaces occur in the path #520

Merged
merged 7 commits into from
Dec 17, 2017
Merged

Fix command spawning when spaces occur in the path #520

merged 7 commits into from
Dec 17, 2017

Commits on Nov 28, 2017

  1. Do not split up command string when passing to ChildProcess

    @mvz
    mvz committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    4eb9a41 View commit details
    Browse the repository at this point in the history

  2. Move Api::Commands to its logical file name

    @mvz
    mvz committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    52f63d0 View commit details
    Browse the repository at this point in the history

  3. Ensure command path is not split

    @mvz
    mvz committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    adc2430 View commit details
    Browse the repository at this point in the history

  4. Fix UnixCommandString#to_a instead

    @mvz
    mvz committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    61a9462 View commit details
    Browse the repository at this point in the history

  5. Handle paths with spaces in WindowsCommandString#to_a

    @mvz
    mvz committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    8ef557a View commit details
    Browse the repository at this point in the history

  6. Test interaction with ChildProcess for unix and windows

    @mvz
    mvz committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    f1aa2a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2017

  1. Remove needless #initialize override

    @mvz
    mvz committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    fedcbce View commit details
    Browse the repository at this point in the history