Fix command spawning when spaces occur in the path #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may need a slightly diffferent approach to not break on Windows. |
|
This is ready for review. |
|
@olleolleolle ok to merge? |
olleolleolle
approved these changes
Dec 17, 2017
| @@ -11,13 +11,18 @@ module Platforms | |||
| # @private | |||
| class WindowsCommandString < SimpleDelegator | |||
| def initialize(cmd) | |||
| __setobj__ format('%s /c "%s"', Aruba.platform.which('cmd.exe'), cmd) | |||
| __setobj__ cmd | |||
There was a problem hiding this comment.
This is the default right? No explicit need to implement the constructor?
There was a problem hiding this comment.
You may be right. I'll take a look.
There was a problem hiding this comment.
Yes, it is no longer needed. I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug in how
ChildProcess.buildwas called. This PR fixes this.Details
Calling
#to_awas called on UnixCommandString representing the executable, splitting the name unnecessarily.Motivation and Context
See #490.
How Has This Been Tested?
A spec was added for this. This still needs to be tested on Windows.
Types of changes
Checklist: