Skip to content

perf(schema-compiler): Remove JSON.stringify in cache key hashing #10404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovr merged 1 commit into from
Feb 17, 2026
+3 −3
Merged

perf(schema-compiler): Remove JSON.stringify in cache key hashing #10404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,7 @@ export class DataSchemaCompiler {
errorsReport: ErrorReporter,
{ cubeNames, cubeSymbols, compilerId, jinjaUsed }: TranspileOptions
): Promise<(FileContent | undefined)> {
const cacheKey = crypto.createHash('md5').update(JSON.stringify(file.content)).digest('hex');
const cacheKey = crypto.createHash('md5').update(file.content).digest('hex');

if (this.compiledYamlCache.has(cacheKey)) {
const content = this.compiledYamlCache.get(cacheKey)!;
Expand Down Expand Up @@ -779,7 +779,7 @@ export class DataSchemaCompiler {
errorsReport: ErrorReporter,
options: TranspileOptions
): Promise<(FileContent | undefined)> {
const cacheKey = crypto.createHash('md5').update(JSON.stringify(file.content)).digest('hex');
const cacheKey = crypto.createHash('md5').update(file.content).digest('hex');

let renderedFileContent: string;

Expand Down Expand Up @@ -861,7 +861,7 @@ export class DataSchemaCompiler {
}

private getJsScript(file: FileContent): vm.Script {
const cacheKey = crypto.createHash('md5').update(JSON.stringify(file.content)).digest('hex');
const cacheKey = crypto.createHash('md5').update(file.content).digest('hex');

if (this.compiledScriptCache.has(cacheKey)) {
return this.compiledScriptCache.get(cacheKey)!;
Expand Down
Loading