perf(schema-compiler): Remove JSON.stringify in cache key hashing#10404
Merged
perf(schema-compiler): Remove JSON.stringify in cache key hashing#10404
Conversation
… hashing file.content is already a string, so JSON.stringify just allocates a full copy with added quotes before feeding it to MD5. Hashing the string directly eliminates ~12MB of throwaway allocations per compilation cycle (200 files x 4 phases), reduces GC pressure, and benchmarks 2.6x faster on the hashing hot path — freeing CPU cycles that were spent copying strings and collecting short-lived garbage.
7b7ca26 to
0cc8314
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10404 +/- ##
===========================================
- Coverage 78.41% 57.42% -20.99%
===========================================
Files 472 222 -250
Lines 92054 17368 -74686
Branches 3555 3555
===========================================
- Hits 72181 9974 -62207
+ Misses 19338 6859 -12479
Partials 535 535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… hashing
file.content is already a string, so JSON.stringify just allocates a full copy with added quotes before feeding it to MD5. Hashing the string directly eliminates ~12MB of throwaway allocations per compilation cycle (200 files x 4 phases), reduces GC pressure, and benchmarks 2.6x faster on the hashing hot path — freeing CPU cycles that were spent copying strings and collecting short-lived garbage.