Reorganize Dockerfile and update scripts. #3
Conversation
As the xtensa-esp32-rust toolchain contains multiple components which
all require their own setup the Dockerfile is rather large. To increase
the maintainability the file got reorganized.
The updated Dockerfile should ...
- expose the expected versions of the toolchain components,
- add a bit more structure to the final container,
- avoid to build and run the llvm tests
- remove unnecessary intermediate artefacts before they
are persisted,
- and replace xargo which is in maintanence mode with cargo-xbuild.
To reflect these changes the scripts got updated as well and all
shellcheck related warnings got fixed.
Also a new `flash-project` executable got added which can be used
to flash the image to `/dev/ttyUSB0`.
0ndorio
force-pushed
the
task/cleanup_scripts
branch
from
74478b2 to
f9bcae2
Compare
|
Updated the pull request to include the latest state of |
|
I could not get the current master container working, but the container from this PR worked well (had to give Docker a lot of resources to build it, though). |
|
Sorry, I really must have overlooked this one. I really like the PR! Thank your for this work. I continued with some re-factoring on the I will do a quick check between develop and master, and see if there is something missing for me. And then I will go ahead and merge this PR. |
|
I reset the develop branch to master, and cherry picked your change. So the develop branch now contains this PR. And will do a build, and see what happens. As you know, this takes a while 😬 but I am on it! |
|
Ok I just noticed that I never declared a license on this project. I added a proper LICENSE file and went with with EPLv2 … just because I always do 😀 … please let me know if that works for you as well. |
Adds missing `flash-project` into containers `/usr/local/bin/`.
EPLv2 is fine for me |
|
Ok cool. I cherry-picked the new commit into develop. And set up GitHub actions so that it can/should push to quay … let's wait a few hours and see what happens 😁 |
|
The image successfully landed at |
Works like a charm! |
|
Thank you for the PR! And for your patience! |
As the xtensa-esp32-rust toolchain contains multiple components which all require their own setup the Dockerfile is rather large. To increase the maintainability I tried to reorganize the file a bit.
The updated Dockerfile should ...
are persisted,
To reflect these changes the scripts got updated as well and all shellcheck related warnings got fixed.
Also a new
flash-projectexecutable got added which can be used to flash the image to/dev/ttyUSB0.Feel free to drop these changes / nitpick as much as you want. I will try to fix upcoming change requests asap.