[Hotfix] Exchange rust-xtensa repository. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it is not possible to compile libcore with the xtensa fork of the rust compiler (rev `bba6c06`). The reasons are some flaws inside the calculation of required registers for argument passing. These bugs got triggered through a recent update of the `compiler_builtins` helper crate which is dynamically injected into the build process of libcore via crates.io. As long as this is the case we are required to use a fork which contains related fixes.
|
No longer required as esp-rs/rust#3 got merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it is not possible to compile libcore with the xtensa fork of the rust compiler (rev
bba6c06esp-rs/rust#2).The reasons are some flaws inside the calculation of required registers to pass function arguments. These got triggered through a recent update of the
compiler_builtinshelper crate which is dynamically injected into the build process of libcore via crates.io.As long as this is the case we must are required to use this fork which contains a bunch of fixes.
A pull request to review & merge these fixes is already open (esp-rs/rust#3).
Btw. thanks for your great work to make this toolchain more usable :)