Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the python version and some other packages #119

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

YoshikiOhtani
Copy link
Collaborator

With this pull request I updated the python version to 3.8 to use a new feature, and accordingly other packages. Removing the requirement on bokeh is needed to update the python version, and regarding sphinx I just let it follow the requirement of the other packages. For the other packages I just updated the versions. @aleberti could you please have a look? Thanks in advance.

@aleberti
Copy link
Collaborator

As we discussed via Slack, if the environment installs fine, I guess there are no problems in merging.

@aleberti
Copy link
Collaborator

Maybe about the lstchain version upgrade: does this affect us? We use lstchain here and there, so maybe we need to be sure it works as before (e.g. in create_dl3_index_files.py and maybe in io.py, where add_delta_t_key is used; I guess that at lower level, i.e. cleaning and muon analysis, nothing has been really changed, I hope, but we can check)

@YoshikiOhtani
Copy link
Collaborator Author

Thanks @aleberti, it is a good point. I looked into the changes on lstchain and it actually affects our pipeline, at least we need to modify create_dl3_index_files. But this is beyond the purpose of this pull request, so I will get the lstchain-related versions to the original ones.

@YoshikiOhtani
Copy link
Collaborator Author

The environment is created successfully, so I will merge it to the master branch.

@YoshikiOhtani YoshikiOhtani merged commit c3c7a7e into master Oct 26, 2022
@YoshikiOhtani YoshikiOhtani deleted the python3.8 branch October 26, 2022 11:47
@YoshikiOhtani YoshikiOhtani mentioned this pull request Oct 31, 2022
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Update the python version and some other packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants