Minor refactoring #113
Merged
Minor refactoring #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshikiOhtani
force-pushed
the
minor-refactor
branch
from
6e46ad3
to
11693c2
Compare
YoshikiOhtani
force-pushed
the
minor-refactor
branch
from
2c96c2a
to
bb29d20
Compare
…-pipe into minor-refactor Conflicts: magicctapipe/scripts/lst1_magic/lst1_magic_dl2_to_dl3.py
…-pipe into minor-refactor
…agic-cta-pipe into minor-refactor
…agic-cta-pipe into minor-refactor
|
I reprocessed my Crab samples with the refactored code to test if it does not make any issues, and finally got consistent results before and after the refactoring. So now I think it is safe enough to merge this branch to the master, so let me do it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request I refactored the combined analysis scripts to simply the code and remove unnecessary processes, as following the previous major refactoring pull request #91. I also updated the docstrings and comments in the code so that people can understand the process more easily. There are no changes on the API so this pull request should be transparent to users. Some bugs and issues were actually found during the refactoring, but they are already fixed by the other pull requests that I recently opened.
One important thing is that I implemented a function
magicctapipe.io.format_objectto pretty-print the configuration, instead of looping over every key and value everywhere in the scripts, and this function only works with python v3.8, with which thesort_dict = Falseargument can be used. I already updated the required python version with the pull request #119, so users must re-create the magic-cta-pipe environment to use the updated scripts. Sorry for the convenience.