Skip to content

html-writer: use the term "finding" #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

html-writer: use the term "finding" #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d4e5d
html-writer: use the term "finding"
siteshwar Jul 25, 2024
fbc99ef
html-writer: rename the `newDefect` CSS class
siteshwar Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/lib/writer-html.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ namespace HtmlLib {
.infoEvent { color:#808080; }
.infoEventComment { color:#00C0C0; }
.traceEvent { color: #C0C0C0; }
.newDefect { color: #00FF00; }
.newFinding { color: #00FF00; }
.parseWarning { color: #FF0000; }
.impFlag { color: #FF0000; font-weight: bold; }
#scanProps { font-family: monospace; }
Expand Down Expand Up @@ -128,7 +128,7 @@ std::string digTitle(const TScanProps &props) {

it = props.find("diffbase-project-name");
if (NA != it) {
title += " - defects not occurring in ";
title += " - findings not occurring in ";
title += it->second;
}

Expand Down Expand Up @@ -296,7 +296,7 @@ void HtmlWriterCore::writeHeaderOnce(
writeScanProps(str_, props);

// initialize the section for defects
HtmlLib::initSection(str_, "List of Defects");
HtmlLib::initSection(str_, "List of Findings");
HtmlLib::initPre(str_);

headerWritten_ = true;
Expand Down Expand Up @@ -399,11 +399,11 @@ void HtmlWriter::setDiffBase(
: it->second;

if (projName.empty()) {
d->newDefMsg = "newly introduced defect";
d->newDefMsg = "newly introduced finding";
return;
}

d->newDefMsg += "defect not occurring in <b>";
d->newDefMsg += "finding not occurring in <b>";
d->newDefMsg += projName;
d->newDefMsg += "</b>";
}
Expand Down Expand Up @@ -462,7 +462,7 @@ void HtmlWriter::Private::writeNewDefWarning(const Defect &def)
return;

// a newly introduced defect
this->str << " <span class='newDefect'>[<b>warning:</b> "
this->str << " <span class='newFinding'>[<b>warning:</b> "
<< this->newDefMsg << "]</span>";
}

Expand Down
Loading
Loading