Skip to content

html-writer: use the term "finding" #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2024
Merged

html-writer: use the term "finding" #197

merged 2 commits into from
Jul 25, 2024

Conversation

siteshwar
Copy link
Member

... instead of "defect" in the reports.

Resolves: #193

@siteshwar siteshwar force-pushed the github-193 branch 2 times, most recently from 0275d0a to e2c24bb Compare July 25, 2024 13:30
@siteshwar
html-writer: use the term "finding"
34d4e5d 
... instead of "defect" in the reports.

Resolves: csutils#193

Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
@siteshwar siteshwar marked this pull request as ready for review July 25, 2024 13:47
@kdudka kdudka self-requested a review July 25, 2024 13:53
kdudka
kdudka reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would also rename the newDefect CSS class to newFinding for consistency.

@siteshwar
html-writer: rename the newDefect CSS class
fbc99ef 
... to `newFinding` for consistency.

Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
@siteshwar
Copy link
Member Author

siteshwar commented Jul 25, 2024 •
edited
Loading

There is also the use of #def in the reports. Shall that be fixed too?

EDIT: My interpretation of #def used to be "definition" and not "defect", so we may skip it unless somebody objects.

@kdudka
Copy link
Member

kdudka commented Jul 25, 2024

Yep, I would keep #def to avoid unnecessary changes in URLs to scan results.

@siteshwar siteshwar merged commit e482bd7 into csutils:main Jul 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdudka kdudka kdudka approved these changes

Assignees

@siteshwar siteshwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shall we use other term than "defects" in the reports?
2 participants
@siteshwar @kdudka