-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor, add {file} template #221
Conversation
* Fix unexpected return tag on non-functions (cschlosser#214) * Prepare release 1.2.1 (cschlosser#215) * Use Github actions instead of travis and appveyor (cschlosser#216) * Switch to GH workflow * Use tslint action * Add build matrix * Run test stage * Disable ubuntu test run due to bug in vscode * Publish coverage on macOS * Remove istanbul * codecov action * Move nyc config to nycrc * Add CD workflow * Remove old publishing script Co-authored-by: Christoph Schlosser <2466365+cschlosser@users.noreply.github.com>
The backend I am talking about mainly uses |
Don't know why the tests process get killed. It's passing all tests and works on my machine |
The CI uses VS Code 1.56.0 now. Are you using 1.55.X locally by any chance?
Thank you, yes I agree with you. But Ad language server: I will review your changes in the upcomming days. |
No it hasn't changed much. You either run another language server along side what the user already uses, which would be stupid or use vscode built-in command to query the user's language server, like |
Did you take a look at this? |
I don't think that's the issue, and indeed I am using 1.56. |
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 93.42% 93.36% -0.07%
==========================================
Files 5 5
Lines 852 814 -38
Branches 247 242 -5
==========================================
- Hits 796 760 -36
+ Misses 56 54 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for your changes.
Will merge it afterwards. CI is fine now too.
* Refactor, add {file} template * Add test for {file} expansion
Fix/Feature/Other
Fix
This closes Option to template filename in file.customTag #191
Feature
Add
{file}
template, so it can be used incustom
tag of both file comments and generic comments.Other
I extracted some functionalities (mainly those
protected
implementation detail functions inCppDocGen.ts
) to dedicated files to better reuse them, because they are not language dependent at the first place, as I am planning to add a backend that uses the language server.I also tried to add documentation to those functions but they may not be accurate. Some function names are quite ambiguous to be honest.