-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unexpected return tag on non-functions #214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
=========================================
Coverage ? 32.03%
=========================================
Files ? 14
Lines ? 1027
Branches ? 188
=========================================
Hits ? 329
Misses ? 696
Partials ? 2
Continue to review full report at Codecov.
|
Thank you for your contribution. Regarding the order of arguments for assertions: This is probably due to the diff being backwards otherwise iirc. |
@cschlosser see this update |
You're totally right. |
* Fix unexpected return tag on non-functions (cschlosser#214) * Prepare release 1.2.1 (cschlosser#215) * Use Github actions instead of travis and appveyor (cschlosser#216) * Switch to GH workflow * Use tslint action * Add build matrix * Run test stage * Disable ubuntu test run due to bug in vscode * Publish coverage on macOS * Remove istanbul * codecov action * Move nyc config to nycrc * Add CD workflow * Remove old publishing script Co-authored-by: Christoph Schlosser <2466365+cschlosser@users.noreply.github.com>
* Fix unexpected return tag on non-functions (cschlosser#214) * Prepare release 1.2.1 (cschlosser#215) * Use Github actions instead of travis and appveyor (cschlosser#216) * Switch to GH workflow * Use tslint action * Add build matrix * Run test stage * Disable ubuntu test run due to bug in vscode * Publish coverage on macOS * Remove istanbul * codecov action * Move nyc config to nycrc * Add CD workflow * Remove old publishing script Co-authored-by: Christoph Schlosser <2466365+cschlosser@users.noreply.github.com>
Fix/Feature/Other
Fix
A dirty fix to #210
Check the special return cases regardless of the setting for including return types. If it is
false
and all the case index is-1
, then theparam
array shall be empty, so it mapped to nothing. Otherwise setparam
to[""]
. So it could be mapped toreturn
, without the types included.I added this test to
config.Test.ts
.NOTE:
All your
test()
calls seems to have wrong order, should betest(actual, expected)
, but you havetest(expected, actual)
.I was so confused at first.