Skip to content

Refactor validations and improve error reporting #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

milux
Copy link
Collaborator

@milux milux commented Mar 21, 2025

Separated validations into individual modules for better modularity. Enhanced ValidationError structure for detailed error reporting, including message and instance path. Updated test cases and references to use the refactored structure.

@milux milux linked an issue Mar 21, 2025 that may be closed by this pull request
Separated validations into individual modules for better modularity. Enhanced ValidationError structure for detailed error reporting, including message and instance path. Updated test cases and references to use the refactored structure.
@milux milux force-pushed the feature/instance-paths-and-refactoring branch from 64f79d1 to 5d9844c Compare March 21, 2025 13:39
@milux milux requested a review from oxisto March 21, 2025 13:40
Copy link
Collaborator

@oxisto oxisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. In general it would be good if we would start to add a little more documentation to the structs and interfaces.

@milux milux merged commit 3735c1a into main Mar 24, 2025
5 checks passed
@milux milux deleted the feature/instance-paths-and-refactoring branch March 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider to use output structure of csaf-validator-lib
2 participants