Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PCRE2 implementation and tests #13105

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Fix PCRE2 implementation and tests #13105

merged 5 commits into from
Feb 22, 2023

Conversation

straight-shoota
Copy link
Member

Resolves #13103

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure topic:stdlib:text labels Feb 22, 2023
@straight-shoota straight-shoota self-assigned this Feb 22, 2023
@beta-ziliani
Copy link
Member

Odd, aarch60-musl-test-stdlib is failing without any useful information 🤔

@straight-shoota
Copy link
Member Author

straight-shoota commented Feb 22, 2023

Yeah, that's odd. Will need to investigate further. But I think we should merge this regardless (the test is broken without this PR also) to fix all the other broken tests.
aarch64-musl-test-stdlib succeeded in #13088 (https://github.com/crystal-lang/crystal/actions/runs/4213098782/jobs/7312598177) and on https://github.com/crystal-lang/crystal/tree/ci/test-pcre2-fixes (https://github.com/crystal-lang/crystal/actions/runs/4234860564/jobs/7357786827).

@beta-ziliani
Copy link
Member

Thanks a bunch Johannes! 🙇

@beta-ziliani beta-ziliani added this to the 1.8.0 milestone Feb 22, 2023
@straight-shoota straight-shoota merged commit 5295ba8 into master Feb 22, 2023
@straight-shoota straight-shoota deleted the fix/pcre2-meta branch February 22, 2023 15:56
@straight-shoota
Copy link
Member Author

I checked std_spec on aarch64_linux-musl manually and it runs fine. So that's good.
No idea why it's failing in CI.

@straight-shoota
Copy link
Member Author

Since this was merged, aarch64_linux-musl succeeded in the latest CI builds on master. I guess it was a fluke then (although it appeared repeatedly, so let's keep our eyes open).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure topic:stdlib:text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aftermath of making PCRE2 the default
2 participants